Skip to content

Conversation

@bparth24
Copy link
Contributor

@bparth24 bparth24 commented Feb 3, 2026

Note:

  • If v2rc2 name is not accurate please guide me.
  • @dlongley this also includes renaming renderEngine to renderSuite. Context: NFC work.

Disclaimer: v2rc2 also contains below NfcRenderingTemplate2024 which was used in some legacy nfc related demos. I would like to point out that this specific method type was not in any of previous release v1 or v1rc1. So if not required I can remove that. My intention to keep it was for backward compatibility.

"NfcRenderingTemplate2024": {
      "@id": "https://w3id.org/vc/render-method#NfcRenderingTemplate2024",
      "@context": {
        "@protected": true,
        "id": "@id",
        "type": "@type",
        "name": "https://schema.org/name",
        "payload": "https://w3id.org/vc/render-method#payload"
      }
    }

@dlongley @davidlehn @BigBlueHat cc: @msporny

Ready for review.

Copy link
Member

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend we actually produce two contexts here. One with the legacy items and the new v2rc2 one. Then we can leave off the legacy context and term definitions when doing new work.

lib/v2rc2.js Outdated
@@ -0,0 +1,94 @@
/*!
* Copyright (c) 2026 Digital Bazaar, Inc. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Copyright (c) 2026 Digital Bazaar, Inc. All rights reserved.
* Copyright (c) 2026 Digital Bazaar, Inc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dlongley

Address in this commit - 5a05712.

@bparth24
Copy link
Contributor Author

bparth24 commented Feb 3, 2026

I recommend we actually produce two contexts here. One with the legacy items and the new v2rc2 one. Then we can leave off the legacy context and term definitions when doing new work.

@dlongley

Addressed in this commit - f398c8f.

Disclaimer: legacy NfcRenderingTemplate2024 was not published in v1 or v1rc1. So keeping it out for the new release v2rc2 for now.

@bparth24 bparth24 requested a review from dlongley February 3, 2026 17:20
Copy link
Member

@davidlehn davidlehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These context packages are a bit particular on how they work at the moment:

  • Add the metadata to lib/index.js
  • Run build script
  • Add the new context/ file to git.

In the future this process will be improved.

@bparth24
Copy link
Contributor Author

bparth24 commented Feb 3, 2026

These context packages are a bit particular on how they work at the moment:

  • Add the metadata to lib/index.js
  • Run build script
  • Add the new context/ file to git.

In the future this process will be improved.

@davidlehn

Addressed in this commit - fbcfca1.

@bparth24 bparth24 requested a review from davidlehn February 3, 2026 19:35
Copy link
Member

@davidlehn davidlehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Fix tests. (probably only 2 to 3 change, tests are simple.)
  • Add new url/name to the test list.
  • This doesn't align with the current spec doc. Should it? Or is it a work in progress?
  • Other things need fixing up if this is to be released. Or is it only to get the context live?

@bparth24
Copy link
Contributor Author

bparth24 commented Feb 3, 2026

  • Fix tests. (probably only 2 to 3 change, tests are simple.)
  • Add new url/name to the test list.

@davidlehn

Addressed above in this commit - 367d024.

@bparth24 bparth24 merged commit 9b33f80 into main Feb 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants