-
Notifications
You must be signed in to change notification settings - Fork 0
Add template render method context #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dlongley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend we actually produce two contexts here. One with the legacy items and the new v2rc2 one. Then we can leave off the legacy context and term definitions when doing new work.
lib/v2rc2.js
Outdated
| @@ -0,0 +1,94 @@ | |||
| /*! | |||
| * Copyright (c) 2026 Digital Bazaar, Inc. All rights reserved. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * Copyright (c) 2026 Digital Bazaar, Inc. All rights reserved. | |
| * Copyright (c) 2026 Digital Bazaar, Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in this commit - f398c8f. Disclaimer: legacy |
davidlehn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These context packages are a bit particular on how they work at the moment:
- Add the metadata to lib/index.js
- Run build script
- Add the new context/ file to git.
In the future this process will be improved.
Addressed in this commit - fbcfca1. |
davidlehn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Fix tests. (probably only 2 to 3 change, tests are simple.)
- Add new url/name to the test list.
- This doesn't align with the current spec doc. Should it? Or is it a work in progress?
- Other things need fixing up if this is to be released. Or is it only to get the context live?
Addressed above in this commit - 367d024. |
Note:
v2rc2name is not accurate please guide me.renderEnginetorenderSuite. Context: NFC work.Disclaimer:
v2rc2also contains belowNfcRenderingTemplate2024which was used in some legacynfcrelated demos. I would like to point out that this specific method type was not in any of previous releasev1orv1rc1. So if not required I can remove that. My intention to keep it was for backward compatibility.@dlongley @davidlehn @BigBlueHat cc: @msporny
Ready for review.