Skip to content

Converting the displaying code of Digraphs from the old version to the graphviz version#639

Closed
mpan322 wants to merge 5 commits intodigraphs:mainfrom
mpan322:main
Closed

Converting the displaying code of Digraphs from the old version to the graphviz version#639
mpan322 wants to merge 5 commits intodigraphs:mainfrom
mpan322:main

Conversation

@mpan322
Copy link
Contributor

@mpan322 mpan322 commented Apr 10, 2024

  • Updated the old displaying code of the digraphs package
  • Added new equivalents which output graphviz objects
  • Updated existing test code so new version passes (validated maually that they are testing the same thing).

@james-d-mitchell james-d-mitchell self-assigned this Apr 17, 2024
@james-d-mitchell james-d-mitchell added not-backwards-compatible A label for PRs that break backwards compatibility major A label for PRs or issues that are major in some sense. refactor Label for PRs or issues related to refactoring code and removed not-backwards-compatible A label for PRs that break backwards compatibility labels Apr 17, 2024
@james-d-mitchell james-d-mitchell mentioned this pull request May 7, 2024
@james-d-mitchell
Copy link
Member

Superseded by #644

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

major A label for PRs or issues that are major in some sense. refactor Label for PRs or issues related to refactoring code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants