Skip to content

Conversation

@avazirna
Copy link
Contributor

@avazirna avazirna commented Jun 11, 2024

Summary

This PR presents an appropriate message to users that have been locked out of CommCare due to exceeding the maximum number of login attempts allowed. To restore the account, users need to reach out to a Supervisor or Administrator.

Note: Another design considered during this work involved receiving a 406 response code from HQ and let the User Actionable errors feature handle the error message, this option was later disfavoured over a 401 response code with specific error messages but it can always be revisited if needed.
Ticket: https://dimagi.atlassian.net/browse/SAAS-13154

Product Description

Currently, when an user is locked out, they get an Invalid Username or Password message. With this change, the message will be:
Screenshot_20240611-141106_CommCare Debug

Safety Assurance

  • I have confidence that this PR will not introduce a regression for the reasons below

Safety story

This PR only improves error message handling on the client side, instead of having a catch-all message for all authentication failure events.

Copy link
Contributor

@shubham1g5 shubham1g5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @avazirna, Can you describe why we decided to not use existing 406 ? It seems like we are duplicating what 406 is designed to do effortlessly with a 401 here but in a more complicated fashion.

@avazirna
Copy link
Contributor Author

@damagatchi retest this please

2 similar comments
@avazirna
Copy link
Contributor Author

@damagatchi retest this please

@avazirna
Copy link
Contributor Author

@damagatchi retest this please

@kishansampat
Copy link

@avazirna any further details on how to carry this PR forward?

@avazirna
Copy link
Contributor Author

@avazirna any further details on how to carry this PR forward?

@kishansampat HQ needs to send a 406 when the user exceeds the number of attempts, as indicated on this ticket: https://dimagi.atlassian.net/browse/SAAS-11660?focusedCommentId=186055. The blocker was that HQ was still sending a 401 instead. I can retest this and create a new ticket for HQ work to make the necessary changes so the changes on this PR can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants