Skip to content

Conversation

@shubham1g5
Copy link
Contributor

@shubham1g5 shubham1g5 commented Sep 11, 2025

Gradle and Kotlin update

Labels and Review

  • Do we need to enhance the manual QA test coverage ? If yes, the "QA Note" label is set correctly
  • Does the PR introduce any major changes worth communicating ? If yes, the "Release Note" label is set and a "Release Note" is specified in PR description.
  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@coderabbitai
Copy link

coderabbitai bot commented Sep 11, 2025

📝 Walkthrough

Walkthrough

Updates Gradle tooling and modernizes Android build configuration. The Android Gradle Plugin is bumped from 8.6.1 to 8.13.0 and the Gradle wrapper from 8.7 to 8.13. In app/build.gradle, deprecated aaptOptions { ignoreAssetsPattern ... } and lintOptions { ... } are replaced with androidResources { ignoreAssetsPattern ... } and lint { ... }. Packaging excludes are consolidated under packagingOptions { resources { excludes += [...] } }, replacing prior explicit excludes. No runtime code or APIs are changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

skip-integration-tests

Suggested reviewers

  • Jignesh-dimagi
  • avazirna
  • pm-dimagi

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

Pre-merge checks (2 passed, 1 warning)

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description is a single line "Gradle and Kotlin update" plus the Labels and Review checklist and does not follow the repository's required template; it is missing the Product Description, a Technical Summary with ticket/link and rationale, Safety Assurance (safety story, automated test coverage, QA plan), and Feature Flag/Release Note details. Because multiple required sections are absent and there is insufficient information to assess safety and QA, the description check fails. Populate the PR description using the repository template: add a Product Description, a Technical Summary with links and rationale, the Safety story, Automated test coverage, and a QA Plan, and state any Feature Flag or Release Note info; update the Labels/checkboxes accordingly and link related tickets or QA tasks.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Title Check ✅ Passed The current title "Bumps gradle, Kotlin and makes relevant changes" correctly highlights the Gradle/AGP bump and general build-related updates, but the provided diff summary documents an AGP/Gradle wrapper update and build.gradle/app/build.gradle adjustments with no explicit Kotlin version change; therefore the title is only partially accurate and may mislead reviewers about a Kotlin bump.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch gradle_bump

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
app/build.gradle (2)

506-509: lintOptions → lint migration is fine; consider scoping disables or moving to lint.xml.

Keeping MissingTranslation/ResourceType disabled globally can hide regressions. If feasible, move these to a lint.xml baseline or scope per variant/task.


247-251: Packaging excludes DSL is fine; optional: rename to packaging

packagingOptions.resources.excludes is the correct API for excluding Java resource paths (works on AGP 7+). (developer.android.com)
Note: the packagingOptions property was renamed to packaging in newer AGP releases — consider switching to android { packaging { resources { ... } } } to avoid deprecation warnings. (developer.android.com)

Verified only occurrence in app/build.gradle — lines 247–249 (rg output).

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 53b0db4 and bd96dda.

📒 Files selected for processing (3)
  • app/build.gradle (2 hunks)
  • build.gradle (1 hunks)
  • gradle/wrapper/gradle-wrapper.properties (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Lint Code Base
🔇 Additional comments (2)
gradle/wrapper/gradle-wrapper.properties (1)

4-4: Add distributionSha256Sum and commit regenerated wrapper artifacts

Add distributionSha256Sum to gradle/wrapper/gradle-wrapper.properties to pin the Gradle 8.13 download. Confirm gradle/wrapper/gradle-wrapper.jar and gradlew(.bat) were regenerated and included in the commit — current verification output only showed the distributionUrl line.

distributionUrl=https\://services.gradle.org/distributions/gradle-8.13-bin.zip
+distributionSha256Sum=<paste official sha256>

Quick checks:

rg -n "distributionUrl" gradle/wrapper/gradle-wrapper.properties
git diff --name-only origin/main...HEAD | rg -n 'gradle/wrapper/gradle-wrapper\.jar|gradlew(\.bat)?'
app/build.gradle (1)

503-505: Correct replacement for deprecated aaptOptions → androidResources.ignoreAssetsPattern.

Syntax and placement under android { } look right.

@shubham1g5 shubham1g5 changed the title bumps gradle and makes relevant changes Bumps gradle, Kotlin and makes relevant changes Sep 12, 2025
@shubham1g5
Copy link
Contributor Author

@damagatchi retest this please

1 similar comment
@shubham1g5
Copy link
Contributor Author

@damagatchi retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants