Cohre/uv impl #1
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the build and dependency management from Poetry to the uv tool across packaging config, CI workflows, documentation, and Makefile targets.
- Introduces a new
pyproject-uv.tomlforuv-based builds and dependencies - Updates Makefile, docs, and workflow files to replace Poetry commands with
uv - Adds setup script and adjusts CI workflows for the new build frontend
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Standardizes extension build logic with setuptools |
| pyproject-uv.toml | New PEP 621 config for uv-based packaging |
| pyproject copy.toml | Duplicate config file (appears unintentional) |
| mkdocs/docs/contributing.md | Doc updates replacing Poetry instructions with uv |
| dev/.rat-excludes | Updated to exclude uv.lock |
| Makefile | Replaced Poetry targets with uv equivalents |
| .github/workflows/*.yml | Swapped make install-poetry & Poetry steps for uv |
| LICENSE | Removed stray leading dash |
Comments suppressed due to low confidence (3)
pyproject copy.toml:1
- The file
pyproject copy.tomlappears to be an accidental duplicate and uses a space in its filename. Consider removing or renaming it to avoid confusion and keep the repository clean.
# Licensed to the Apache Software Foundation (ASF) under one
mkdocs/docs/contributing.md:37
- This line was meant as a bullet but is missing the leading dash and space. Change to
- For the development, uv is used ...to maintain proper Markdown list formatting.
For the development, uv is used for packing and dependency management. You can install this using:
.github/workflows/nightly-pypi-build.yml:29
- [nitpick] The nightly build workflow no longer sets
CIBW_BUILD_FRONTEND: "build[uv]". If you want to mirror the artifact builds, add that env var so wheels are built with theuvfrontend.
# if: github.repository == 'apache/iceberg-python' # Only run for apache repo
| "Programming Language :: Python :: 3.12", | ||
| ] | ||
| dependencies = [ | ||
| "python=^3.9.2,!=3.9.7", |
There was a problem hiding this comment.
Python version constraints should be declared under requires-python rather than in dependencies. Move python=^3.9.2,!=3.9.7 to requires-python to follow PEP 621 conventions.
Suggested change
| "python=^3.9.2,!=3.9.7", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Are these changes tested?
Are there any user-facing changes?