Add 'visible' param when creating a topic #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @oblakeerickson, have you had a moment to review this small change? 😄 |
pmusaraj
approved these changes
Dec 9, 2025
pmusaraj
left a comment
pmusaraj
left a comment
There was a problem hiding this comment.
Thanks @thomasrossetto, looks good.
If you're up for improving this upstream (in core) so the visible parameter can be returned by the API, I'd be happy to look into that as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Based on the existing code, I’ve added this parameter so we can create a topic and control its visibility.
Unfortunately, the parameter isn’t officially documented in the API, but it does work correctly.
However, the response doesn’t include any visibility information, so I’m not able to add a test for it.
Let me know if this change is okay for you or if you’d prefer something different.
Thanks!