Precompute values and cache attrname to prevent few lookups #1558
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small improvement to
bulk_history_createwith the intent to reduce the number of Python calls, by memoizing a piece of the entries and avoiding duplicated lookupsRelated Issue
#1563
Motivation and Context
When updating a large number of records, it was noticed that a considerable portion of the execution time was expended calling methods related to
get_default_history_user,tmezone.now(), andhasattrHow Has This Been Tested?
The current code was tested against a dataset used in production using the pyinstrument library to profile the code execution.
Testing Environment
TestModelmodel having ~20 tracked fieldsProfiling script
Profiling results
Code from the main branch:
Code from this branch:
Screenshots (if appropriate):
Types of changes
Checklist:
pre-commit runcommand to format and lint.AUTHORS.rstCHANGES.rst