the RESET 'if' is incorrect#12
Open
juggledad wants to merge 1 commit intodkern:masterfrom
juggledad:master
Open
the RESET 'if' is incorrect#12juggledad wants to merge 1 commit intodkern:masterfrom juggledad:master
juggledad wants to merge 1 commit intodkern:masterfrom
juggledad:master
Conversation
the reset if will fail it msg.reset is a zero because msg.reset will evaluate to FALSE. This change will check to see if msg.reset is a number and then continue if it is.
Owner
|
Thank you for your PR. You are correct, there is a bug. But your "fix" will is make impossible to use if( msg.hasOwnProperty("reset") && (typeof msg.reset === "number" || msg.reset === true) { |
|
I was just going to do my own PR and then saw this. I tested the code below with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the reset if will fail it msg.reset is a zero because msg.reset will evaluate to FALSE. This change will check to see if msg.reset is a number and then continue if it is.