releases: fallback to github api if github cdn fails#696
Draft
crazy-max wants to merge 1 commit intodocker:mainfrom
Draft
releases: fallback to github api if github cdn fails#696crazy-max wants to merge 1 commit intodocker:mainfrom
crazy-max wants to merge 1 commit intodocker:mainfrom
Conversation
7ed19b2 to
aabf1f0
Compare
0256c6b to
739746b
Compare
7b6177a to
a5680dc
Compare
2 tasks
Member
|
Why aren't we just including the token in the headers to the request to https://raw.githubusercontent.com ? |
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
a5680dc to
23b2076
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to https://github.com/docker/actions-toolkit/actions/runs/15138332709/job/42555459875?pr=696#step:3:3646
Seems related to recent changes in GitHub infra: https://github.blog/changelog/2025-05-08-updated-rate-limits-for-unauthenticated-requests/
Didn't find any documentation for rate-limit of GitHub CDNs like
raw.githubusercontent.combut I recall it was 5000 requests per hour per IP. Also nothing documented about authentication against their CDNs to avoid rate-limit. I tried with a bearer token but no dice.So to avoid being rate-limited when fetching releases JSON payload we fallback to the GitHub API https://docs.github.com/en/rest/repos/contents?apiVersion=2022-11-28#get-repository-content if CDN fails.