Fix gw priority network order #13512
Open
+100
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pnkcaht <samzoovsk19@gmail.com>
Signed-off-by: pnkcaht <samzoovsk19@gmail.com>
Pnkcaht
force-pushed
the
fix-gw-priority-network-order
branch
2 times, most recently
from
28d7e90 to
1e3fc17
Compare
ndeloof
requested changes
Jan 15, 2026
Contributor
ndeloof
left a comment
ndeloof
left a comment
There was a problem hiding this comment.
orderEndpointsByGwPriority returns a map, so won't fix any ordering issue
Also, AFAIK there's no ordering requirements after the priority attribute has been introduced - this was non determinist before this API change, without any workaround.
Is this PR related to an identified issue or just a tentative fix exploring the codebase?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Adjusted how
NetworkingConfig.EndpointsConfigis built so that networks are ordered bygw_prioritybefore being sent to the Docker Engine.Previously, even when gw_priority was defined in the Compose file, the order of endpoints passed to the Engine was non-deterministic due to map iteration.
This change ensures endpoints are explicitly ordered by descending gw_priority, matching the expected Compose semantics and Docker Engine behavior.
A helper function was introduced in
defaultNetworkSettingsto sort endpoint settings before constructingNetworkingConfig, and a unit test was added to validate the ordering.Related issue
Fixes #13511
(not mandatory) A picture of a cute animal, if possible in relation to what you did
🐳 Carefully routing containers through the right gateway
Notes
gw_priorityconfigured