Fix docker compose down removing images still in use #13515
+73
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pnkcaht <samzoovsk19@gmail.com>
Signed-off-by: pnkcaht <samzoovsk19@gmail.com>
Pnkcaht
force-pushed
the
fix-compose-down-image-ownership
branch
from
f1063f6 to
5a669d2
Compare
ndeloof
requested changes
Jan 15, 2026
Contributor
ndeloof
left a comment
ndeloof
left a comment
There was a problem hiding this comment.
engine detects image are in use by another container, simpler (imho) to let it manage this check (which will then not suffer from potential race conditions) and manage error during image removal attempts
| ) | ||
|
|
||
| // ImagePruneMode controls how aggressively images associated with the project | ||
| // are removed from the engine. |
Contributor
There was a problem hiding this comment.
why did you remove all comments?
Member
There was a problem hiding this comment.
I suspect it was written with AI, which has a tendency on doing so; I see various other changes (and comments added) that match that idea as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Adjusted the image pruning logic used by
docker compose downto avoid removing images that are still in use by existing containers.Before this change, Compose could attempt to remove images that were still referenced by running or stopped containers belonging to the same project, which resulted in unexpected behavior and errors during
down --rmi.The pruner now checks containers associated with the project and filters out images that are currently in use before scheduling them for removal.
Related issue
Fixes #13491
(not mandatory) A picture of a cute animal, if possible in relation to what you did
🐳 A whale carefully carrying containers instead of dropping them — just like Compose now avoids removing images that are still in use.
Notes
docker compose downwith image removal enabledTestDownRemoveImages,TestDownRemoveImages_NoLabel)