Warn when unsupported deploy attribute is used in docker compose #13517
+27
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pnkcaht <samzoovsk19@gmail.com>
Pnkcaht
force-pushed
the
feat/warn-unsupported-attributes
branch
from
361da93 to
02186fb
Compare
ndeloof
reviewed
Jan 15, 2026
| for _, service := range project.Services { | ||
| if service.Deploy != nil { | ||
| logrus.Warnf( | ||
| "Service %q uses 'deploy' which is not supported by docker compose and will be ignored", |
Contributor
There was a problem hiding this comment.
that's wrong. most of deploy section is ignored by compose, but some attributes are considered. Typically replica and some device requests (used for gpu support)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added a warning when unsupported Compose attributes are detected during project
loading. Currently this warns when the
deploysection is used, which isignored by docker compose outside of Swarm mode.
This avoids silent misconfiguration and makes it clear to users why
deploysettings are not applied when running docker compose outside of Swarm mode.
Related issue
Fixes #13150
Related to #13149
(not mandatory) A picture of a cute animal, if possible in relation to what you did
🐶 A vigilant watchdog barking loudly when something unsupported sneaks in — just like Compose now warns users when
deployis defined outside of Swarm mode.Notes
deployattribute is present in a service definitionwarnings.gohelper to keep the logic isolatedgo build ./cmd/composego test ./cmd/compose/...Screenshot
Build and tests passing locally