Add github-token input to readme#185
Conversation
|
It was not put in the readme on purpose as the github token is not required: setup-docker-action/action.yml Line 40 in efe9e38 Does it fail on your side? If so can you show some logs? Thanks! |
|
When running on a action triggered from GitHub Enterprise Cloud, the error in the action log is: (with v4.5.0) In v4.4.0 the action works fine too. When setting the input to a The main learning here is that https://docs.github.com/en/enterprise-cloud@latest/admin/data-residency/network-details-for-ghecom |
|
I think it is completely fine to rely on the default |
Signed-off-by: polarctos <polarctos@users.noreply.github.com>
Version v4.5.0 introduced usage of the GitHub token for downloads.
Unfortunately this change was not backwards compatible on GitHub Enterprise instances (
<company>.ghe.com) as the downloads require a token forgithub.com, and not the token from the dedicated GHE server/cloud which is present ingithub.token. Maybe a new majorv5would have been nice.This PR just adds the
github-tokeninput to the readme to make it easier for GHE users to discover this input and to pass in a github.com token e.g. from a secret.