Skip to content

Conversation

@V1nc3ntWasTaken
Copy link
Collaborator

By creating a pull request, you agree to the following
  • The code included in this PR is in no way malicious, or used for my personal gain.
  • The code included in this PR is intended to benefit, add a universal feature, fix a bug(s), or make a function more efficient.
  • The code included in this PR is not intended for one time use/personal use. (ex. compatibility with your personal plugin)
  • The code included in this PR follows the licensing of it's origination.
  • The code included in this PR is tested, and follows all laws, regulations, rules, and other listed restrictions.

Type of Change

What type of fix(es) are included in this pull request?

  • Bug Fix
  • New Feature
  • Other (Describe below)

Other (Only applies if Other is selected above)


  • Maven dependency update

Link(s) to related issue(s) and their issue number(s)

List of links to issues that this PR relates to or closes

  • None

Changes

Describe all the changes that were made

  • Added io.netty: netty-transport

Testing Required

Do the applied changes require testing? (Depends on if core components were changed)

  • Yes, these changes require testing
  • No, these changes do not require testing
Testing Environment (If the above is Yes)

1.19 Tests

  • Server Distribution (CraftBukkit, Spigot, Purpur, and it's build number):
  • Tested player joining
  • Tested chats Player -> Server
  • Tested command chats Player -> Server (Using /tell, /me, /say, etc.)
  • Tested chats Server -> Player (Using /say, /me, etc.)
  • Tested chat formatting (Using third party plugins such as TownyChat, EssentialsXChat, etc.)
  • Tested Reflection with above

1.19.1 Tests

  • Server Distribution (CraftBukkit, Spigot, Purpur, and it's build number):
  • Tested player joining
  • Tested chats Player -> Server
  • Tested command chats Player -> Server (Using /tell, /me, /say, etc.)
  • Tested chats Server -> Player (Using /say, /me, etc.)
  • Tested chat formatting (Using third party plugins such as TownyChat, EssentialsXChat, etc.)
  • Tested Reflection with above

1.19.2 Tests

  • Server Distribution (CraftBukkit, Spigot, Purpur, and it's build number):
  • Tested player joining
  • Tested chats Player -> Server
  • Tested command chats Player -> Server (Using /tell, /me, /say, etc.)
  • Tested chats Server -> Player (Using /say, /me, etc.)
  • Tested chat formatting (Using third party plugins such as TownyChat, EssentialsXChat, etc.)
  • Tested Reflection with above

1.19.3 Tests

  • Server Distribution (CraftBukkit, Spigot, Purpur, and it's build number):
  • Tested player joining
  • Tested chats Player -> Server
  • Tested command chats Player -> Server (Using /tell, /me, /say, etc.)
  • Tested chats Server -> Player (Using /say, /me, etc.)
  • Tested chat formatting (Using third party plugins such as TownyChat, EssentialsXChat, etc.)
  • Tested Reflection with above

1.19.4 Tests

  • Server Distribution (CraftBukkit, Spigot, Purpur, and it's build number):
  • Tested player joining
  • Tested chats Player -> Server
  • Tested command chats Player -> Server (Using /tell, /me, /say, etc.)
  • Tested chats Server -> Player (Using /say, /me, etc.)
  • Tested chat formatting (Using third party plugins such as TownyChat, EssentialsXChat, etc.)
  • Tested Reflection with above

Self Review

  • I have performed a self-review of my code
  • My code successfully compiles through Maven every time, without any compiler warnings
  • My code has been checked for leftover development code/comments such as debug outputs

@V1nc3ntWasTaken V1nc3ntWasTaken added the enhancement New feature or request label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants