Replaces reload prompts with quit for asset changes#290
Replaces reload prompts with quit for asset changes#290MiguVT wants to merge 1 commit intodoki-theme:mainfrom
Conversation
Updates user guidance and notifications to prompt for quitting VSCode instead of reloading the window after asset installation or removal. Aims to reduce unsupported warning persistence and improve clarity for users, aligning documentation and UI with the new flow.
|
The description itself was generated with AI because I think its a really simple thing that an AI could easily handle to explain, in the code no AI was used because it was really simple task. |
|
Also made it because I talked about that here: #286 |
There was a problem hiding this comment.
Pull request overview
Updates user-facing guidance for applying asset changes by moving away from “reload window” wording and toward quitting/restarting VS Code, and refreshes documentation navigation to match.
Changes:
- Updated onboarding and README instructions to say “Restart VSCode” instead of “Reload/Restart VSCode”.
- Changed asset install/uninstall notifications to offer a “Quit” action and execute
workbench.action.quit. - Adjusted changelog wording related to code-server refresh/restart guidance.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/WelcomeService.ts |
Updates the onboarding “Sample Usage” step to “Restart VSCode”. |
src/ThemeManager.ts |
Updates install/uninstall messaging and switches the notification action from reload to quit. |
README.md |
Updates restart wording and expands/restructures the documentation table of contents. |
CHANGELOG.md |
Updates code-server guidance wording (“hard reload” → “hard restart”). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
|
|
||
| const quickReloadAction = "Quickly Reload Window"; | ||
| const QuitAction = "Quit"; |
There was a problem hiding this comment.
QuitAction is a file-level constant but uses PascalCase, whereas the previous quickReloadAction (and other non-type constants in this file) use camelCase / uppercase-constant styles. Rename to a consistent constant style (e.g., quitAction / quitActionTitle or QUIT_ACTION).
| const QuitAction = "Quit"; | |
| const quitAction = "Quit"; |
| vscode.window | ||
| .showInformationMessage( | ||
| `Removed All Images. ${handleInstallMessage}`, | ||
| { title: quickReloadAction } | ||
| { title: QuitAction } | ||
| ) | ||
| .then((item) => { | ||
| if (item) { | ||
| vscode.commands.executeCommand("workbench.action.reloadWindow"); | ||
| vscode.commands.executeCommand("workbench.action.quit"); | ||
| } |
There was a problem hiding this comment.
Same concern as the install flow: invoking workbench.action.quit from the uninstall notification may not work in web-based hosts (code-server), leaving users without an effective one-click path. Consider the same Desktop/Web guard + fallback here as well.
| - Added the ability to control the position & size of the sticker using the `doki.sticker.css` configruation property. | ||
| - Fixed artifacted background images on the extension list tree & settings UI selected config (be sure to re-install your wallpaper for this to take effect). | ||
| - Restored asset installation on code-server (please be sure to clear caches and hard reload!) | ||
| - Restored asset installation on code-server (please be sure to clear caches and hard restart!) |
There was a problem hiding this comment.
“hard restart” is not a commonly understood action for code-server/web usage (where “hard reload”/cache-busting refresh is the typical instruction). This wording may make the guidance harder to follow; consider reverting to “hard reload” here or clarifying what the user should actually do (browser hard refresh vs restarting a server process).
| - Restored asset installation on code-server (please be sure to clear caches and hard restart!) | |
| - Restored asset installation on code-server (please be sure to clear caches and perform a hard reload of VS Code in your browser!) |
|
|
||
| const FIRST_TIME_STICKER_INSTALL = "doki.sticker.first.install"; | ||
| export const handleInstallMessage = `Quick reload to see changes, please restart VSCode to remove the Unsupported warning.` | ||
| export const handleInstallMessage = `Restart to see changes, please restart VSCode to remove the Unsupported warning.` |
There was a problem hiding this comment.
handleInstallMessage is user-facing and now reads “Restart to see changes, please restart VSCode…”. This is both redundant and ambiguous about what to restart, and it no longer matches the notification action label (“Quit”). Consider rewriting to a single, consistent instruction (e.g., explicitly “Quit and re-open VSCode …”) and reusing the same wording as the action button.
| export const handleInstallMessage = `Restart to see changes, please restart VSCode to remove the Unsupported warning.` | |
| export const handleInstallMessage = `Quit and re-open VS Code to apply changes and remove the Unsupported warning.`; |
1 participant
Updates user guidance and notifications to prompt for quitting VSCode instead of reloading the window after asset installation or removal. Aims to reduce unsupported warning persistence and improve clarity for users, aligning documentation and UI with the new flow.
Description
This pull request focuses on improving the user experience by clarifying instructions and updating the terminology around restarting VSCode. It also reorganizes and enhances the documentation structure for better readability. The most significant changes are:
User Experience Improvements:
README.md,CHANGELOG.md, notification messages, and onboarding instructions. [1] [2] [3] [4] [5] [6] [7]Documentation Enhancements:
README.mdby adding new sections, improving the table of contents, and clarifying configuration and miscellaneous options. This makes it easier for users to find relevant information and understand the available features.Motivation and Context
Fixes #269 and #263
Types of changes
Checklist:
I can update changelog but I need to know what version will be next as there is no [Unreleased] entry