Add fast path for simple IN filters
#3330
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reltuk
approved these changes
Dec 5, 2025
Contributor
reltuk
left a comment
reltuk
left a comment
There was a problem hiding this comment.
LGTM. Only concern, brought up offline, is verifying overflow behavior is correct for the signed <-> unsigned cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are filtering an indexed column with a simple
INquery, we can avoid building a range tree.This currently only applies to integer columns, but it's possible to expand it to floats and decimals.
Also, simplifies rounding checks for float/decimal keys on integer indexes.
Benchmarks:
dolthub/dolt#10133 (comment)