Skip to content

add php stubs for IDE support #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andheiberg wants to merge 1 commit into
base: master
Choose a base branch
from
+20 −0
Open

add php stubs for IDE support #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions stubs/GraphQL/Error/ParseError.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<?php

Copy link
Owner

@dosten dosten Feb 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is required to add a copyright notice here:

/*
 * This file is part of the GraphQL parser extension.
 *
 * (c) Diego Saint Esteben <diego@saintesteben.me>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace GraphQL\Error;

class ParseError extends \Exception {}
Copy link
Owner

@dosten dosten Feb 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, ParseError extends from RuntimeException

15 changes: 15 additions & 0 deletions stubs/GraphQL/Parser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<?php

Copy link
Owner

@dosten dosten Feb 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, (probably) missing copyright notice.

namespace GraphQL;

class Parser
{
/**
Copy link
Owner

@dosten dosten Feb 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a simple description for this method?

* @param string $input
*
* @return array
*/
public function parse(string $input): array {
Copy link
Owner

@dosten dosten Feb 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't works for versions before 7.0 right? Can you remove the type hint and the return type?

return [];
}
}