fix: Skip properties that have no getter method during scanning#2984
Open
y1hao wants to merge 1 commit intodotnet:masterfrom
Open
fix: Skip properties that have no getter method during scanning#2984y1hao wants to merge 1 commit intodotnet:masterfrom
y1hao wants to merge 1 commit intodotnet:masterfrom
Conversation
Author
|
@dotnet-policy-service agree |
Collaborator
|
Can you also add an analyzer rule for it? |
Author
|
Sure. I haven't written analyzer rules before though, will take a look this weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2980.
When a property that's used as
ParamSourcehas no getter method (a write-only property),BenchmarkConverter.GetValidValuesForParamsSource()throwsNullReferenceException. This PR makes it skip such write-only property since they can't be used as the param source, this will result in anInvalidBenchmarkDeclarationExceptionwhich is clearer.