Skip to content

chore: Enable nullable on build/common.props #3013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timcassell merged 2 commits into from
Feb 20, 2026
+1 −17
Merged

chore: Enable nullable on build/common.props #3013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b564e6
chore: enable nullable on common.props
filzrev Feb 19, 2026
3c723aa
chore: remove condition that is not currently used
filzrev Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/common.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)CodingStyle.ruleset</CodeAnalysisRuleSet>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsNotAsErrors>NU1900</WarningsNotAsErrors>
<Nullable Condition="'$(Nullable)' == ''">annotations</Nullable>
<Nullable>enable</Nullable>
<!-- Suppress warning for nuget package used in old (unsupported) tfm. -->
<SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings>
</PropertyGroup>
Expand Down
1 change: 0 additions & 1 deletion samples/BenchmarkDotNet.Samples.FSharp/BenchmarkDotNet.Samples.FSharp.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
<GenerateProgramFile>false</GenerateProgramFile>
<!-- Disable parallel tests between TargetFrameworks -->
<TestTfmsInParallel>false</TestTfmsInParallel>
<Nullable>enable</Nullable>
</PropertyGroup>
<ItemGroup>
<Compile Include="Program.fs" />
Expand Down
1 change: 0 additions & 1 deletion samples/BenchmarkDotNet.Samples/BenchmarkDotNet.Samples.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
<GenerateProgramFile>false</GenerateProgramFile>
<!-- Disable parallel tests between TargetFrameworks -->
<TestTfmsInParallel>false</TestTfmsInParallel>
<Nullable>enable</Nullable>
</PropertyGroup>
<ItemGroup Condition=" '$(TargetFrameworkIdentifier)' == '.NETFramework' ">
<Reference Include="System.Reflection" />
Expand Down
2 changes: 0 additions & 2 deletions src/BenchmarkDotNet.Annotations/Attributes/ParamsAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
using System;

#nullable enable

namespace BenchmarkDotNet.Attributes
{
[AttributeUsage(AttributeTargets.Field | AttributeTargets.Property)]
Expand Down
1 change: 0 additions & 1 deletion src/BenchmarkDotNet.Annotations/BenchmarkDotNet.Annotations.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
<RootNamespace>BenchmarkDotNet</RootNamespace>
<!-- needed for docfx xref resolver -->
<ProduceReferenceAssembly>True</ProduceReferenceAssembly>
<Nullable>enable</Nullable>
</PropertyGroup>
<!-- Settings for PolySharp -->
<PropertyGroup>
Expand Down
1 change: 0 additions & 1 deletion src/BenchmarkDotNet.Diagnostics.Windows/BenchmarkDotNet.Diagnostics.Windows.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
<NoWarn>1701;1702;1705;1591;3001;3003;3002;3009</NoWarn>
<AssemblyName>BenchmarkDotNet.Diagnostics.Windows</AssemblyName>
<PackageId>BenchmarkDotNet.Diagnostics.Windows</PackageId>
<Nullable>enable</Nullable>
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\BenchmarkDotNet\BenchmarkDotNet.csproj" />
Expand Down
1 change: 0 additions & 1 deletion src/BenchmarkDotNet.Diagnostics.dotMemory/BenchmarkDotNet.Diagnostics.dotMemory.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
<AssemblyTitle>BenchmarkDotNet.Diagnostics.dotMemory</AssemblyTitle>
<AssemblyName>BenchmarkDotNet.Diagnostics.dotMemory</AssemblyName>
<PackageId>BenchmarkDotNet.Diagnostics.dotMemory</PackageId>
<Nullable>enable</Nullable>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 0 additions & 1 deletion src/BenchmarkDotNet.Diagnostics.dotTrace/BenchmarkDotNet.Diagnostics.dotTrace.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
<AssemblyTitle>BenchmarkDotNet.Diagnostics.dotTrace</AssemblyTitle>
<AssemblyName>BenchmarkDotNet.Diagnostics.dotTrace</AssemblyName>
<PackageId>BenchmarkDotNet.Diagnostics.dotTrace</PackageId>
<Nullable>enable</Nullable>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 0 additions & 1 deletion src/BenchmarkDotNet.Disassembler/BenchmarkDotNet.Disassembler.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
<PlatformTarget>x64</PlatformTarget>
<!-- This project is only used for debugging the disassembler, it's not included in any BenchmarkDotNet packages. -->
<IsPackable>false</IsPackable>
<Nullable>enable</Nullable>
</PropertyGroup>
<PropertyGroup>
<RootNamespace>BenchmarkDotNet.Disassembler</RootNamespace>
Expand Down
1 change: 0 additions & 1 deletion src/BenchmarkDotNet.Exporters.Plotting/BenchmarkDotNet.Exporters.Plotting.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
<RootNamespace>BenchmarkDotNet.Exporters.Plotting</RootNamespace>
<!-- needed for docfx xref resolver -->
<ProduceReferenceAssembly>True</ProduceReferenceAssembly>
<Nullable>enable</Nullable>
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\BenchmarkDotNet\BenchmarkDotNet.csproj" />
Expand Down
1 change: 0 additions & 1 deletion src/BenchmarkDotNet.TestAdapter/BenchmarkDotNet.TestAdapter.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
<AssemblyName>BenchmarkDotNet.TestAdapter</AssemblyName>
<PackageId>BenchmarkDotNet.TestAdapter</PackageId>
<ProduceReferenceAssembly>True</ProduceReferenceAssembly>
<Nullable>enable</Nullable>
</PropertyGroup>

<!-- Use minimum supported LTSC version of Visual Studio 2022 -->
Expand Down
2 changes: 0 additions & 2 deletions src/BenchmarkDotNet.TestAdapter/VSTestEventProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@
using System.Text;
using System.Threading;

#nullable enable

namespace BenchmarkDotNet.TestAdapter
{
/// <summary>
Expand Down
1 change: 0 additions & 1 deletion src/BenchmarkDotNet.Weaver/BenchmarkDotNet.Weaver.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ then run `build.cmd pack-weaver`.
<DelaySign>false</DelaySign>
<!-- Fix error NU5017: Cannot create a package that has no dependencies nor content. -->
<IsPackable Condition="'$(IsFullPack)' == 'true'">false</IsPackable>
<Nullable>enable</Nullable>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 0 additions & 1 deletion src/BenchmarkDotNet/BenchmarkDotNet.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
<RootNamespace>BenchmarkDotNet</RootNamespace>
<!-- needed for docfx xref resolver -->
<ProduceReferenceAssembly>True</ProduceReferenceAssembly>
<Nullable>enable</Nullable>
</PropertyGroup>
<ItemGroup>
<EmbeddedResource Include="Templates\*" Exclude="bin\**;obj\**;**\*.xproj;packages\**;@(EmbeddedResource)" />
Expand Down
1 change: 0 additions & 1 deletion tests/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<Project>
<PropertyGroup>
<Nullable>enable</Nullable>
<GenerateDocumentationFile>false</GenerateDocumentationFile>
<IsPackable>false</IsPackable>
</PropertyGroup>
Expand Down