Skip to content

Conversation

@akoeplinger
Copy link
Member

1ES PT expects an object with the container image, not just the name. Use the same azureLinux30Net10BuildAmd64 container as we do in other jobs since we only build managed code.

1ES PT expects an object with the container image, not just the name.
Use the same  azureLinux30Net10BuildAmd64 container as we do in other jobs since we only build managed code.
@akoeplinger akoeplinger requested review from a team and wtgodbe as code owners December 15, 2025 11:39
Copilot AI review requested due to automatic review settings December 15, 2025 11:39
@github-actions github-actions bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Dec 15, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects the container image specification for the source-build job in official builds to comply with 1ES Pipeline Template requirements. The change updates from a hardcoded container image string to a properly defined container object reference.

Key Changes:

  • Changed container from string literal 'mcr.microsoft.com/dotnet-buildtools/prereqs:centos-stream-10-amd64' to variable reference azureLinux30Net10BuildAmd64

@akoeplinger akoeplinger enabled auto-merge (squash) December 15, 2025 13:59
@akoeplinger akoeplinger merged commit 8d32470 into main Dec 15, 2025
32 checks passed
@akoeplinger akoeplinger deleted the fix-sourcebuild branch December 15, 2025 14:57
@dotnet-policy-service dotnet-policy-service bot added this to the 11.0-preview1 milestone Dec 15, 2025
@akoeplinger
Copy link
Member Author

/backport to release/10.0

@akoeplinger
Copy link
Member Author

/backport to release/9.0

@github-actions
Copy link
Contributor

Started backporting to release/10.0 (link to workflow run)

@akoeplinger
Copy link
Member Author

/backport to release/8.0

@github-actions
Copy link
Contributor

Started backporting to release/9.0 (link to workflow run)

@github-actions
Copy link
Contributor

Started backporting to release/8.0 (link to workflow run)

@github-actions
Copy link
Contributor

@akoeplinger backporting to release/9.0 failed, the patch most likely resulted in conflicts. Please backport manually!

git am output
$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Pass container image correctly for source-build job in official build
Using index info to reconstruct a base tree...
M	.azure/pipelines/ci.yml
Falling back to patching base and 3-way merge...
Auto-merging .azure/pipelines/ci.yml
CONFLICT (content): Merge conflict in .azure/pipelines/ci.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Pass container image correctly for source-build job in official build
Error: The process '/usr/bin/git' failed with exit code 128

Link to workflow output

@github-actions
Copy link
Contributor

@akoeplinger backporting to release/8.0 failed, the patch most likely resulted in conflicts. Please backport manually!

git am output
$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Pass container image correctly for source-build job in official build
Using index info to reconstruct a base tree...
M	.azure/pipelines/ci.yml
Falling back to patching base and 3-way merge...
Auto-merging .azure/pipelines/ci.yml
CONFLICT (content): Merge conflict in .azure/pipelines/ci.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Pass container image correctly for source-build job in official build
Error: The process '/usr/bin/git' failed with exit code 128

Link to workflow output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants