-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Pass container image correctly for source-build job in official build #64770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1ES PT expects an object with the container image, not just the name. Use the same azureLinux30Net10BuildAmd64 container as we do in other jobs since we only build managed code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR corrects the container image specification for the source-build job in official builds to comply with 1ES Pipeline Template requirements. The change updates from a hardcoded container image string to a properly defined container object reference.
Key Changes:
- Changed
containerfrom string literal'mcr.microsoft.com/dotnet-buildtools/prereqs:centos-stream-10-amd64'to variable referenceazureLinux30Net10BuildAmd64
|
/backport to release/10.0 |
|
/backport to release/9.0 |
|
Started backporting to |
|
/backport to release/8.0 |
|
Started backporting to |
|
Started backporting to |
|
@akoeplinger backporting to git am output$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Pass container image correctly for source-build job in official build
Using index info to reconstruct a base tree...
M .azure/pipelines/ci.yml
Falling back to patching base and 3-way merge...
Auto-merging .azure/pipelines/ci.yml
CONFLICT (content): Merge conflict in .azure/pipelines/ci.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Pass container image correctly for source-build job in official build
Error: The process '/usr/bin/git' failed with exit code 128 |
|
@akoeplinger backporting to git am output$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Pass container image correctly for source-build job in official build
Using index info to reconstruct a base tree...
M .azure/pipelines/ci.yml
Falling back to patching base and 3-way merge...
Auto-merging .azure/pipelines/ci.yml
CONFLICT (content): Merge conflict in .azure/pipelines/ci.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Pass container image correctly for source-build job in official build
Error: The process '/usr/bin/git' failed with exit code 128 |
…official build Backport of #64770
…official build Backport of #64770
1ES PT expects an object with the container image, not just the name. Use the same azureLinux30Net10BuildAmd64 container as we do in other jobs since we only build managed code.