Conversation
Evangelink
requested review from
a team,
Youssef1313,
gewarren and
meaghanlewis
as code owners
There was a problem hiding this comment.
Pull request overview
This pull request reworks the MSTest documentation to be feature-oriented, following up on PR #50979. The changes reorganize documentation from an attribute-centric structure to a feature-based organization that better supports developers learning MSTest.
Changes:
- Deleted the comprehensive attributes page (
unit-testing-mstest-writing-tests-attributes.md) and redistributed content into feature-specific documents - Created new feature-oriented documentation files: data-driven testing, lifecycle management, execution control, and test organization
- Reorganized the table of contents to group documentation by testing concepts rather than API elements
- Updated cross-references throughout the documentation
- Added redirects for deleted/moved pages
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
docs/navigate/devops-testing/toc.yml |
Reorganized MSTest section, moved framework order (MSTest first, then NUnit, xUnit) |
docs/navigate/devops-testing/index.yml |
Updated link from runner intro to running tests overview |
docs/core/testing/unit-testing-mstest-writing-tests.md |
Rewrote as feature overview with quick reference tables |
docs/core/testing/unit-testing-mstest-writing-tests-organizing.md |
New file covering test metadata and organization attributes |
docs/core/testing/unit-testing-mstest-writing-tests-lifecycle.md |
Expanded lifecycle documentation with detailed examples |
docs/core/testing/unit-testing-mstest-writing-tests-data-driven.md |
New comprehensive guide to data-driven testing |
docs/core/testing/unit-testing-mstest-writing-tests-controlling-execution.md |
New guide for execution control attributes |
docs/core/testing/unit-testing-mstest-writing-tests-assertions.md |
Enhanced assertions documentation |
docs/core/testing/unit-testing-mstest-intro.md |
Expanded overview with platform support details |
docs/core/testing/unit-testing-mstest-getting-started.md |
Restructured getting started guide |
docs/core/testing/unit-testing-mstest-sdk.md |
Updated to focus on configuration |
docs/core/testing/unit-testing-mstest-running-tests.md |
Consolidated runner information from deleted intro file |
| Language-specific tutorials (C#, F#, VB) | Updated titles for consistency |
| Analyzer documentation | Updated cross-references to new document structure |
.openpublishing.redirection.core.json |
Added redirects for deleted pages |
| ms.date: 08/30/2017 | ||
| --- | ||
| # Unit testing F# libraries in .NET Core using dotnet test and MSTest | ||
| # Get started with MSTest and F\# |
There was a problem hiding this comment.
Incorrect use of escaped hash character in title. The title should be "# Get started with MSTest and F#" not "# Get started with MSTest and F#". The backslash before the hash is unnecessary and will render incorrectly. The hash character doesn't need escaping in markdown headings.
| ai-usage: ai-assisted | ||
| --- | ||
| # Unit testing C# with MSTest and .NET | ||
| # Get started with MSTest and C\# |
There was a problem hiding this comment.
Incorrect use of escaped hash character in title. The title should be "# Get started with MSTest and C#" not "# Get started with MSTest and C#". The backslash before the hash is unnecessary and will render incorrectly. The hash character doesn't need escaping in markdown headings.
| public static IEnumerable<int> GetData() | ||
| { | ||
| yield return 1; | ||
| yield return 2; | ||
| yield return 3; |
There was a problem hiding this comment.
Return type mismatch in GetData method. The method returns IEnumerable<int> but should return IEnumerable<object[]> to work with the DynamicData attribute. Each data row should be wrapped in an object array. Change the return type to IEnumerable<object[]> and wrap each value: yield return new object[] { 1 };
| public static IEnumerable<int> GetData() | |
| { | |
| yield return 1; | |
| yield return 2; | |
| yield return 3; | |
| public static IEnumerable<object[]> GetData() | |
| { | |
| yield return new object[] { 1 }; | |
| yield return new object[] { 2 }; | |
| yield return new object[] { 3 }; |
| 1. Run DisposeAsync if implemented | ||
| 1. Run Dispose if implemented | ||
| - [Write tests in MSTest](unit-testing-mstest-writing-tests.md) | ||
| - [Write tests in MSTest](unit-testing-mstest-writing-tests.md) |
There was a problem hiding this comment.
Duplicate link in the "See also" section. The link to "Write tests in MSTest" appears twice on consecutive lines. Remove one of these duplicate entries.
| - [Write tests in MSTest](unit-testing-mstest-writing-tests.md) |
| ## See also | ||
|
|
||
| - [Write tests in MSTest](unit-testing-mstest-writing-tests.md) | ||
| - [Write tests in MSTest](unit-testing-mstest-writing-tests.md) |
There was a problem hiding this comment.
Duplicate link in the "See also" section. The link to "Write tests in MSTest" appears twice on consecutive lines. Remove one of these duplicate entries.
| - [Write tests in MSTest](unit-testing-mstest-writing-tests.md) |
| ## See also | ||
|
|
||
| - [Write tests in MSTest](unit-testing-mstest-writing-tests.md) | ||
| - [Write tests in MSTest](unit-testing-mstest-writing-tests.md) |
There was a problem hiding this comment.
Duplicate link in the "See also" section. The link to "Write tests in MSTest" appears twice on consecutive lines. Remove one of these duplicate entries.
| - [Write tests in MSTest](unit-testing-mstest-writing-tests.md) |
1 participant
Summary
Follow-up changes from #50979 (comment)
Internal previews
Toggle expand/collapse