Skip to content

Comments

Support joining SQL Server full-text/vector search TVFs as inner#37631

Merged
roji merged 2 commits intodotnet:mainfrom
roji:SqlServerTvfs
Feb 5, 2026
Merged

Support joining SQL Server full-text/vector search TVFs as inner#37631
roji merged 2 commits intodotnet:mainfrom
roji:SqlServerTvfs

Conversation

@roji
Copy link
Member

@roji roji commented Feb 5, 2026

Part of #11487

@roji roji requested a review from a team as a code owner February 5, 2026 11:06
Copilot AI review requested due to automatic review settings February 5, 2026 11:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds support for joining SQL Server full-text search table-valued functions (TVFs) to the main entity tables in LINQ queries. This is part of the broader implementation of FREETEXTTABLE and CONTAINSTABLE functionality.

Changes:

  • Added navigation expansion support for FreeTextTable and ContainsTable in the query pipeline to enable joining these TVFs with entity tables
  • Added a test demonstrating the Join method pattern for FreeTextTable TVF

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/EFCore/Query/Internal/NavigationExpandingExpressionVisitor.cs Added special handling for SQL Server full-text search TVFs (FreeTextTable and ContainsTable) to support joining them with entity tables in navigation expansion
test/EFCore.SqlServer.FunctionalTests/Query/Translations/FullTextSearchTranslationsSqlServerTest.cs Added test case demonstrating explicit Join method usage with FreeTextTable TVF

@roji roji changed the title Support joining SQL Server full-text search TVFs Support joining SQL Server full-text search TVFs as inner Feb 5, 2026
@roji roji enabled auto-merge (squash) February 5, 2026 13:30
@roji roji disabled auto-merge February 5, 2026 13:55
Copilot AI review requested due to automatic review settings February 5, 2026 14:06
@roji roji changed the title Support joining SQL Server full-text search TVFs as inner Support joining SQL Server full-text/vector search TVFs as inner Feb 5, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this will be fixed properly by rc1

@roji
Copy link
Member Author

roji commented Feb 5, 2026

Yeah, that would definitely be the plan.

@roji roji requested a review from AndriySvyryd February 5, 2026 18:31
@roji roji enabled auto-merge (squash) February 5, 2026 18:35
@roji
Copy link
Member Author

roji commented Feb 5, 2026

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@roji roji merged commit 1732188 into dotnet:main Feb 5, 2026
10 checks passed
@roji roji deleted the SqlServerTvfs branch February 5, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SQL Server full-text search: FREETEXTTABLE and CONTAINSTABLE table-valued functions

2 participants