Support joining SQL Server full-text/vector search TVFs as inner#37631
Merged
roji merged 2 commits intodotnet:mainfrom Feb 5, 2026
Merged
Support joining SQL Server full-text/vector search TVFs as inner#37631roji merged 2 commits intodotnet:mainfrom
roji merged 2 commits intodotnet:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds support for joining SQL Server full-text search table-valued functions (TVFs) to the main entity tables in LINQ queries. This is part of the broader implementation of FREETEXTTABLE and CONTAINSTABLE functionality.
Changes:
- Added navigation expansion support for FreeTextTable and ContainsTable in the query pipeline to enable joining these TVFs with entity tables
- Added a test demonstrating the Join method pattern for FreeTextTable TVF
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/EFCore/Query/Internal/NavigationExpandingExpressionVisitor.cs | Added special handling for SQL Server full-text search TVFs (FreeTextTable and ContainsTable) to support joining them with entity tables in navigation expansion |
| test/EFCore.SqlServer.FunctionalTests/Query/Translations/FullTextSearchTranslationsSqlServerTest.cs | Added test case demonstrating explicit Join method usage with FreeTextTable TVF |
...Core.SqlServer.FunctionalTests/Query/Translations/FullTextSearchTranslationsSqlServerTest.cs
Show resolved
Hide resolved
AndriySvyryd
reviewed
Feb 5, 2026
AndriySvyryd
reviewed
Feb 5, 2026
Member
AndriySvyryd
left a comment
There was a problem hiding this comment.
Hopefully this will be fixed properly by rc1
Member
Author
|
Yeah, that would definitely be the plan. |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
AndriySvyryd
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #11487