[clr-interp] Convert call stub logging to LOG2 facility

[Copilot]

Description

Converts interpreter call stub logging from compile-time #if LOG_COMPUTE_CALL_STUB blocks to runtime-controllable LOG2 facility. These logging statements have proven valuable for debugging but required recompilation to enable.

Changes

• Added LF2_INTERPRETER = 0x00000002 to LogFacility2 enum
• Converted 26 logging instances to LOG2((LF2_INTERPRETER, LL_INFO10000, ...))
• Removed #define LOG_COMPUTE_CALL_STUB 0
• Updated INVOKE_FUNCTION_PTR and RETURN_TYPE_HANDLER macros

Before

#define LOG_COMPUTE_CALL_STUB 0

PCODE GetGPRegRangeRoutine(int r1, int r2)
{
#if LOG_COMPUTE_CALL_STUB
    printf("GetGPRegRangeRoutine %d %d\n", r1, r2);
#endif
    // ...
}

After

PCODE GetGPRegRangeRoutine(int r1, int r2)
{
    LOG2((LF2_INTERPRETER, LL_INFO10000, "GetGPRegRangeRoutine %d %d\n", r1, r2));
    // ...
}

Logging now enabled via: DOTNET_LogFacility2=0x2 DOTNET_LogLevel=10000

Original prompt

---

This section details on the original issue you should resolve

<issue_title>[clr-interp] Convert logging in call stubs to use logging facility</issue_title>
<issue_description>I think we should convert it to the LOG mechanism. When I wrote these logging statements, I had thought they would likely be very temporary, but I've used them 4-5 times since then, so they have some ongoing value. However, I'd like to see that work done in a separate PR. We should convert them to using LOG statements probably with a new LF enum value. Probably what should be done is add a new log facility enum in log.h, call it LF2_INTERPRETER. And convert these log statements to use the LOG2 macro, with info level LL_INFO10000 instead of wrapping them in #if LOG_COMPUTE_CALL_STUB blocks.

Originally posted by @davidwrighton in #123142 (comment)
</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes [clr-interp] Convert logging in call stubs to use logging facility #123272

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[dotnet-policy-service]

Tagging subscribers to this area: @BrzVlad, @janvorli, @kg
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR converts interpreter call stub logging from compile-time preprocessor directives to runtime-controllable LOG2 facility, making debugging more convenient without requiring recompilation.

Changes:

• Added LF2_INTERPRETER to the LogFacility2 enum for runtime-controlled interpreter logging
• Converted 26 compile-time #if LOG_COMPUTE_CALL_STUB logging blocks to runtime LOG2((LF2_INTERPRETER, LL_INFO10000, ...)) calls
• Removed the LOG_COMPUTE_CALL_STUB preprocessor define and updated associated macros

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/coreclr/inc/log.h	Added LF2_INTERPRETER = 0x00000002 to LogFacility2 enum for interpreter logging
src/coreclr/vm/callstubgenerator.cpp	Removed LOG_COMPUTE_CALL_STUB define and converted all 26 logging statements from compile-time #if blocks to runtime LOG2 calls; updated INVOKE_FUNCTION_PTR and RETURN_TYPE_HANDLER macros