Enable linux-x64 for TechEmpower SPMI scenarios #123742
Draft
+10
−243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @dotnet/jit-contrib |
Member
Author
|
/azp run runtime-coreclr superpmi-collect-test |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-coreclr superpmi-collect-test |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
Enables running the crank-based TechEmpower (aspnet2) SuperPMI collection on linux-x64 by redirecting NuGet caches away from $HOME to avoid OS disk exhaustion.
Changes:
- Redirect NuGet cache/package locations to the scenario working directory in the aspnet2 crank runner.
- Simplify the generated
localhost.ymlendpoints for the crank Localhost profile. - Enable
linux_x64for the aspnet2 collection job in the SuperPMI collect pipeline template.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/coreclr/scripts/superpmi_aspnet2.py |
Moves NuGet caches/packages into the work directory and simplifies Localhost profile endpoint generation. |
eng/pipelines/coreclr/templates/superpmi-collect-pipeline.yml |
Enables linux_x64 for aspnet2 collection, but also removes many other SuperPMI collection matrices from the shared template. |
Comments suppressed due to low confidence (1)
eng/pipelines/coreclr/templates/superpmi-collect-pipeline.yml:262
- This change removes all the previously-defined SuperPMI collection matrices (libraries pmi/crossgen2/run/run_pgo, realworld/benchmarks, nativeaot, and libraries test-run collections). Since both
eng/pipelines/coreclr/superpmi-collect.ymlandsuperpmi-collect-test.ymlextend this template, they will now only run the aspnet2 collection, which looks like a significant behavior change unrelated to enabling linux_x64. If the removal isn’t intentional, restore the deleted job matrices (or move them to a different template and keep this one aspnet2-specific).
#
# Collection of aspnet/TechEmpower benchmarks (crank-based): aspnet2
#
- template: /eng/pipelines/common/platform-matrix.yml
parameters:
This was referenced Jan 30, 2026
Member
Author
|
/azp run runtime-coreclr superpmi-collect-test |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This scenario was failing on Linux-x64 due to "ran out of disk space". Apparently that was nuget stuff in $HOME (OS disk).