[release/10.0] __ComObject doesn't support dynamic interface map (redux)
#123762
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #123725 to release/10.0
/cc @AaronRobinsonMSFT
Customer Impact
In #112375 a fix was checked in with insufficient validation. An issue was reported offline that uncovered a deficiency in that fix and the validation. This PR revisits that issue for .NET 10, adds the missing test cases, and adds comments on the utility of the dynamic interface map.
The regression is the casting of built-in COM interop objects to some managed (COM and non-COM) interfaces, depending on how the COM object enters the runtime. Occasionally there are workarounds, but in the most recent offline issue the workaround is very impactful.
Re fixes #112371
Regression
The PR that originally started this all off was #105965.
Testing
Added and verified tests for the original reported test and the one described offline - all now pass. Both the original OP reported issue and most recent issue were verifiied fixed with this change.
Risk
Low to Medium. The risk here isn't destabilizing issue, but rather introducing or not fixing a regression on some important niche scenario from the original change, #105965. This change is also considered low risk because this change represents a much more targeted change relative to the change that introduced the regression (that is, the additional of a new interface on the
__ComObjectwhen previously it had none).