-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[release/8.0-staging] Bump iOS & tvOS queues #123768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/8.0-staging
Are you sure you want to change the base?
Conversation
All MacOS 13 queues no longer exist.
| # tvOS devices | ||
| - ${{ if in(parameters.platform, 'tvos_arm64') }}: | ||
| - OSX.13.Amd64.AppleTV.Open | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a YML-master... is this (now deleted) whitespace line important, or no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, indentation does. Blank lines don't
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request updates the Helix queue configurations for iOS and tvOS device testing from macOS 13 to macOS 15, as the macOS 13 queues are no longer available.
Changes:
- Updates iOS device queue from
OSX.13.Amd64.Iphone.OpentoOSX.15.Amd64.Iphone.Open - Updates tvOS device queue from
OSX.13.Amd64.AppleTV.OpentoOSX.15.Amd64.AppleTV.Open
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/pipelines/libraries/helix-queues-setup.yml | Updates iOS and tvOS device queue configurations to use OSX.15 instead of OSX.13 for library tests |
| eng/pipelines/coreclr/templates/helix-queues-setup.yml | Updates iOS and tvOS device queue configurations to use OSX.15 instead of OSX.13 for CoreCLR tests |
| - ${{ if in(parameters.platform, 'tvos_arm64') }}: | ||
| - OSX.13.Amd64.AppleTV.Open | ||
|
|
||
| - OSX.15.Amd64.AppleTV.Open |
Copilot
AI
Jan 29, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation of this line is inconsistent with the rest of the file. This line has 8 spaces of indentation, but it should have 6 spaces to match the iOS devices entry on line 59 and other queue entries in this file. This inconsistent indentation could cause YAML parsing issues or make the configuration harder to maintain.
| - OSX.15.Amd64.AppleTV.Open | |
| - OSX.15.Amd64.AppleTV.Open |
All MacOS 13 queues no longer exist.