Skip to content

Conversation

@steveisok
Copy link
Member

All MacOS 13 queues no longer exist.

All MacOS 13 queues no longer exist.
@steveisok steveisok requested review from a team and Copilot January 29, 2026 18:25
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jan 29, 2026
@steveisok steveisok added the Servicing-approved Approved for servicing release label Jan 29, 2026
# tvOS devices
- ${{ if in(parameters.platform, 'tvos_arm64') }}:
- OSX.13.Amd64.AppleTV.Open

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a YML-master... is this (now deleted) whitespace line important, or no?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, indentation does. Blank lines don't

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the Helix queue configurations for iOS and tvOS device testing from macOS 13 to macOS 15, as the macOS 13 queues are no longer available.

Changes:

  • Updates iOS device queue from OSX.13.Amd64.Iphone.Open to OSX.15.Amd64.Iphone.Open
  • Updates tvOS device queue from OSX.13.Amd64.AppleTV.Open to OSX.15.Amd64.AppleTV.Open

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
eng/pipelines/libraries/helix-queues-setup.yml Updates iOS and tvOS device queue configurations to use OSX.15 instead of OSX.13 for library tests
eng/pipelines/coreclr/templates/helix-queues-setup.yml Updates iOS and tvOS device queue configurations to use OSX.15 instead of OSX.13 for CoreCLR tests

- ${{ if in(parameters.platform, 'tvos_arm64') }}:
- OSX.13.Amd64.AppleTV.Open

- OSX.15.Amd64.AppleTV.Open
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation of this line is inconsistent with the rest of the file. This line has 8 spaces of indentation, but it should have 6 spaces to match the iOS devices entry on line 59 and other queue entries in this file. This inconsistent indentation could cause YAML parsing issues or make the configuration harder to maintain.

Suggested change
- OSX.15.Amd64.AppleTV.Open
- OSX.15.Amd64.AppleTV.Open

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants