Skip to content

Fix length when getting property from host #123774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elinor-fung wants to merge 2 commits into
base: main
Choose a base branch
from
+19 −5
Open

Fix length when getting property from host #123774

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5074f1
Fix length when getting property from host
elinor-fung Jan 29, 2026
edd5c98
Update src/coreclr/vm/hostinformation.cpp
elinor-fung Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions src/coreclr/vm/hostinformation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,24 +23,38 @@ bool HostInformation::GetProperty(_In_z_ const char* name, SString& value)
return false;

size_t len = MAX_PATH + 1;
char* dest = value.OpenUTF8Buffer(static_cast<COUNT_T>(len));
char* dest = value.OpenUTF8Buffer(static_cast<COUNT_T>(len) - 1); // OpenUTF8Buffer already includes a byte for the null terminator
// get_runtime_property returns the length including a null terminator
size_t lenActual = s_hostContract.get_runtime_property(name, dest, len, s_hostContract.context);
value.CloseBuffer();

// Doesn't exist or failed to get property
if (lenActual == (size_t)-1 || lenActual == 0)
{
value.CloseBuffer(0);
return false;
}

if (lenActual <= len)
{
value.CloseBuffer(static_cast<COUNT_T>(lenActual) - 1);
return true;
}

value.CloseBuffer();

// Buffer was not large enough
len = lenActual;
dest = value.OpenUTF8Buffer(static_cast<COUNT_T>(len));
dest = value.OpenUTF8Buffer(static_cast<COUNT_T>(len) - 1); // OpenUTF8Buffer already includes a byte for the null terminator
lenActual = s_hostContract.get_runtime_property(name, dest, len, s_hostContract.context);
value.CloseBuffer();

return lenActual > 0 && lenActual <= len;
if (lenActual == (size_t)-1 || lenActual == 0 || lenActual > len)
{
value.CloseBuffer(0);
return false;
}

value.CloseBuffer(static_cast<COUNT_T>(lenActual) - 1);
return true;
}

bool HostInformation::HasExternalProbe()
Expand Down
Loading