Skip to content

Conversation

@AiYuZhen
Copy link
Collaborator

@AiYuZhen AiYuZhen commented Jan 31, 2026

增加上下文菜单项反排序。
增加 TrimStartAndEndDivider 参数,确保开始及结尾菜单项不是分割线。

Link issues

fixes #7605

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Add configurable trimming of leading and trailing dividers and support ordered rendering for context menu items.

New Features:

  • Introduce a TrimStartAndEndDivider parameter on ContextMenu to optionally remove leading and trailing divider items from the rendered menu.
  • Add an Order parameter to context menu items and dividers to control their display order within the menu.

Tests:

  • Add unit tests covering trimming of start/end dividers and ordered rendering of context menu items.

增加上下文菜单项反排序。
增加 TrimStartAndEndDivider 参数,确定开始及结尾菜单项不是分割线。
@bb-auto
Copy link

bb-auto bot commented Jan 31, 2026

Thanks for your PR, @AiYuZhen. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 31, 2026

Reviewer's Guide

Implements explicit ordering for context menu items and dividers, and adds an option to trim leading/trailing dividers from rendered context menus, with accompanying unit tests.

Sequence diagram for rendering ordered and trimmed context menu

sequenceDiagram
  actor User
  participant Browser
  participant ContextMenu

  User->>Browser: Right click target
  Browser->>ContextMenu: Render context menu
  ContextMenu->>ContextMenu: GetContextMenuItems()
  activate ContextMenu
  ContextMenu->>ContextMenu: Sort _contextMenuItems by Order
  alt TrimStartAndEndDivider enabled
    ContextMenu->>ContextMenu: Remove leading ContextMenuDivider items
    ContextMenu->>ContextMenu: Remove trailing ContextMenuDivider items
  end
  ContextMenu-->>Browser: Ordered and trimmed items
  deactivate ContextMenu
  Browser-->>User: Display context menu
Loading

Class diagram for ordered and trimmed context menu items

classDiagram

class ContextMenu {
  +RenderFragment ChildContent
  +bool TrimStartAndEndDivider
  -List~IContextMenuItem~ _contextMenuItems
  -List~IContextMenuItem~ GetContextMenuItems()
}

class IContextMenuItem {
  +int Order
}

class ContextMenuItem {
  +string Text
  +int Order
}

class ContextMenuDivider {
  +int Order
}

ContextMenuItem ..|> IContextMenuItem
ContextMenuDivider ..|> IContextMenuItem
ContextMenu o--> IContextMenuItem
Loading

File-Level Changes

Change Details Files
Add TrimStartAndEndDivider option and centralized item filtering/ordering logic for ContextMenu rendering.
  • Introduce TrimStartAndEndDivider boolean parameter on the context menu component to control trimming of leading and trailing divider items.
  • Add GetContextMenuItems helper that sorts menu items by their Order property and conditionally removes divider items from the start and end of the collection.
  • Update the ContextMenu.razor markup to iterate over the filtered/sorted items from GetContextMenuItems instead of the raw backing list.
src/BootstrapBlazor/Components/ContextMenu/ContextMenu.razor.cs
src/BootstrapBlazor/Components/ContextMenu/ContextMenu.razor
Introduce per-item ordering support across context menu items and dividers via IContextMenuItem.
  • Extend IContextMenuItem interface with an Order property to define display order of menu entries.
  • Add Order parameter implementation to ContextMenuItem and ContextMenuDivider so they both participate in ordering.
src/BootstrapBlazor/Components/ContextMenu/IContextMenuItem.cs
src/BootstrapBlazor/Components/ContextMenu/ContextMenuItem.cs
src/BootstrapBlazor/Components/ContextMenu/ContextMenuDivider.cs
Add unit tests to validate trimming behavior and ordering of context menu items and dividers.
  • Add ContextMenu_TrimStartAndEndDivider_Ok test to assert that leading and trailing dividers are removed when trimming is enabled while preserving inner dividers.
  • Add ContextMenuItem_Order_Ok test to assert that items and dividers are rendered in ascending Order and that the markup applies the correct CSS classes.
test/UnitTest/Components/ContextMenuTest.cs

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot requested a review from ArgoZhang January 31, 2026 03:53
@bb-auto bb-auto bot added the enhancement New feature or request label Jan 31, 2026
@bb-auto bb-auto bot added this to the v10.2.0 milestone Jan 31, 2026
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Jan 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (856d896) to head (a6920ca).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #7608   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          749       749           
  Lines        33003     33005    +2     
  Branches      4580      4580           
=========================================
+ Hits         33003     33005    +2     
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ArgoZhang ArgoZhang changed the title feat(ContextMenu)增加菜单项排序 #7605 feat(IContextMenuItem): add IsShow parameter Jan 31, 2026
ArgoZhang
ArgoZhang previously approved these changes Jan 31, 2026
@ArgoZhang ArgoZhang modified the milestones: v10.2.0, v10.3.0 Jan 31, 2026
@ArgoZhang ArgoZhang merged commit 66ec4ce into main Jan 31, 2026
4 checks passed
@ArgoZhang ArgoZhang deleted the Feat_ContextMenu branch January 31, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(IContextMenuItem): add IsShow parameter

3 participants