Add future annotations for TYPE_CHECKING compatibility #881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `from __future__ import annotations` to settings.py and base_controller.py to enable proper deferred evaluation of type annotations. This is required when using TYPE_CHECKING imports to avoid runtime NameError when the imported types are used in function signatures. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
github-actions
bot
added
server
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
from __future__ import annotationstosettings.pyandbase_controller.pyTYPE_CHECKINGimportsNameErrorwhen imported types are used in function signaturesThis is a prerequisite for PR #880 (Server Side Version Checker).
🤖 Generated with Claude Code