Updated Renovate config to only update deps in the root of the project.#2277
Updated Renovate config to only update deps in the root of the project.#2277AlexSkrypnyk merged 1 commit intomainfrom
Conversation
WalkthroughAdded Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@renovate.json`:
- Around line 94-98: The Container images group ("groupName": "Container
images") currently only matches ".docker/**" via the matchFileNames array, so
updates detected by the custom regex manager for the root docker-compose.yml are
excluded; update the matchFileNames array for the Container images rule to also
include "docker-compose.yml" (in addition to ".docker/**") so root
docker-compose file updates are grouped under "Container images" and inherit its
schedule and settings.
| "groupName": "Container images", | ||
| "groupSlug": "docker", | ||
| "matchFileNames": [ | ||
| ".docker/**" | ||
| ], |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# First, let's check if renovate.json exists and read the relevant sections
cd "$(git rev-parse --show-toplevel)" 2>/dev/null || cd .
if [ -f renovate.json ]; then
echo "=== renovate.json exists ==="
wc -l renovate.json
echo ""
echo "=== Lines 90-105 (Container images rule) ==="
sed -n '90,105p' renovate.json
echo ""
echo "=== Lines 120-130 (Custom regex manager) ==="
sed -n '120,130p' renovate.json
else
echo "renovate.json not found at root"
fiRepository: drevops/vortex
Length of output: 1014
🏁 Script executed:
# Check for docker-compose files and Dockerfiles
fd -a -t f \( -name 'docker-compose.yml' -o -name 'docker-compose.yaml' -o -name 'Dockerfile*' \) | head -20Repository: drevops/vortex
Length of output: 288
🏁 Script executed:
# Check for docker-compose files and Dockerfiles
find . -type f \( -name 'docker-compose.yml' -o -name 'docker-compose.yaml' -o -name 'Dockerfile' \) 2>/dev/null | grep -v '.git'Repository: drevops/vortex
Length of output: 1453
🏁 Script executed:
# Let's also see the full Container images rule section to understand the complete logic
sed -n '94,110p' renovate.jsonRepository: drevops/vortex
Length of output: 530
🏁 Script executed:
# Check what files are in the .docker directory
find ./.docker -type f 2>/dev/null | head -20Repository: drevops/vortex
Length of output: 920
🏁 Script executed:
# Let's also view the complete custom manager section to understand the full picture
sed -n '119,132p' renovate.jsonRepository: drevops/vortex
Length of output: 477
🏁 Script executed:
# Let's see if there are any images defined in the root docker-compose.yml that would be affected
head -50 ./docker-compose.ymlRepository: drevops/vortex
Length of output: 2565
🏁 Script executed:
# Let's also check if there are Dockerfiles in .docker that define container images
head -20 ./.docker/cli.dockerfileRepository: drevops/vortex
Length of output: 657
Root docker-compose.yml updates won't be grouped under "Container images" due to matchFileNames filter.
The Container images rule (lines 94-110) restricts grouping to .docker/** files, but the custom regex manager at lines 119-132 targets the root docker-compose.yml. This mismatch means image updates from docker-compose.yml will bypass the "Container images" group and its "before 3am" schedule, despite the custom regex manager being explicitly designed to extract them.
Add docker-compose.yml to the matchFileNames array to ensure consistency:
✅ Suggested fix
"matchFileNames": [
- ".docker/**"
+ ".docker/**",
+ "docker-compose.yml"
],📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "groupName": "Container images", | |
| "groupSlug": "docker", | |
| "matchFileNames": [ | |
| ".docker/**" | |
| ], | |
| "groupName": "Container images", | |
| "groupSlug": "docker", | |
| "matchFileNames": [ | |
| ".docker/**", | |
| "docker-compose.yml" | |
| ], |
🤖 Prompt for AI Agents
In `@renovate.json` around lines 94 - 98, The Container images group ("groupName":
"Container images") currently only matches ".docker/**" via the matchFileNames
array, so updates detected by the custom regex manager for the root
docker-compose.yml are excluded; update the matchFileNames array for the
Container images rule to also include "docker-compose.yml" (in addition to
".docker/**") so root docker-compose file updates are grouped under "Container
images" and inherit its schedule and settings.
|
|
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2277 +/- ##
==========================================
- Coverage 77.05% 76.44% -0.61%
==========================================
Files 114 107 -7
Lines 5988 5829 -159
Branches 44 0 -44
==========================================
- Hits 4614 4456 -158
+ Misses 1374 1373 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 participant
Summary by CodeRabbit