-
Notifications
You must be signed in to change notification settings - Fork 3
refactor: Optimize Lambda packages size #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR optimizes Lambda package sizes by adding cleanup steps to remove unnecessary files and implementing size validation in the CI/CD workflow.
Changes:
- Added
--no-cache-dirflag to pip install commands to reduce package size - Implemented cleanup of test directories, cache files, bytecode, and metadata directories
- Added CI workflow steps to validate both compressed and uncompressed Lambda package sizes against the 250 MB AWS limit
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| packages/dsw-mailer/Makefile | Added --no-cache-dir flag and cleanup steps to remove tests, cache, bytecode, and metadata files from Lambda package |
| packages/dsw-data-seeder/Makefile | Applied same optimization changes as dsw-mailer for consistency |
| .github/workflows/lambda.yml | Added size validation checks for both compressed and uncompressed Lambda packages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d563faa to
bd52b16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bd52b16 to
1d0cc49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.