Skip to content

[runner] Check if repo dir exists before chown #3589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
un-def merged 1 commit into from
Feb 19, 2026
Merged

[runner] Check if repo dir exists before chown #3589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions runner/internal/executor/repo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,16 +236,25 @@ func (ex *RunExecutor) restoreRepoDir(ctx context.Context, tmpDir string) error

func (ex *RunExecutor) chownRepoDir(ctx context.Context) error {
log.Trace(ctx, "Chowning repo dir")
exists, err := common.PathExists(ex.repoDir)
// We consider all errors here non-fatal
if err != nil {
log.Warning(ctx, "Failed to check if repo dir exists", "err", err)
return nil
}
if !exists {
log.Trace(ctx, "Repo dir does not exist")
return nil
}
return filepath.WalkDir(
ex.repoDir,
func(p string, d fs.DirEntry, err error) error {
// We consider walk/chown errors non-fatal
if err != nil {
log.Debug(ctx, "Error while walking repo dir", "path", p, "err", err)
log.Warning(ctx, "Error while walking repo dir", "path", p, "err", err)
return nil
}
if err := os.Chown(p, ex.jobUser.Uid, ex.jobUser.Gid); err != nil {
log.Debug(ctx, "Error while chowning repo dir", "path", p, "err", err)
log.Warning(ctx, "Error while chowning repo dir", "path", p, "err", err)
}
return nil
},
Expand Down