Skip to content

Fix concurrent indexes migration #3591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
r4victor merged 1 commit into from
Feb 19, 2026
+18 −1
Merged

Fix concurrent indexes migration #3591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/dstack/_internal/server/migrations/env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def run_migrations(connection: Connection):
# lock_timeout is needed so that migrations that acquire locks
# do not wait for locks forever, blocking live queries.
# Better to fail and retry a deployment.
connection.execute(text("SET lock_timeout='10s';"))
connection.execute(text("SET lock_timeout='15s';"))
connection.commit()
context.configure(
connection=connection,
Expand Down
17 changes: 17 additions & 0 deletions ...migrations/versions/2026/02_18_1122_a8ed24fd7f90_add_pipeline_indexes_for_compute_and_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,21 @@
def upgrade() -> None:
# ### commands auto generated by Alembic - please adjust! ###
with op.get_context().autocommit_block():
if op.get_context().dialect.name == "postgresql":
# Concurrent index ops can fail midway, leaving invalid indexes behind.
# Use DROP INDEX IF EXISTS so the migration can be retried safely.
op.drop_index(
"ix_compute_groups_pipeline_fetch_q",
table_name="compute_groups",
if_exists=True,
postgresql_concurrently=True,
)
op.drop_index(
"ix_placement_groups_pipeline_fetch_q",
table_name="placement_groups",
if_exists=True,
postgresql_concurrently=True,
)
op.create_index(
"ix_compute_groups_pipeline_fetch_q",
"compute_groups",
Expand Down Expand Up @@ -47,11 +62,13 @@ def downgrade() -> None:
op.drop_index(
"ix_placement_groups_pipeline_fetch_q",
"placement_groups",
if_exists=True,
postgresql_concurrently=True,
)
op.drop_index(
"ix_compute_groups_pipeline_fetch_q",
"compute_groups",
if_exists=True,
postgresql_concurrently=True,
)
# ### end Alembic commands ###