-
Notifications
You must be signed in to change notification settings - Fork 46
improved cron job: handle non-existent repo gracefully #660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds error handling for HTTP fetch requests by checking the response status and throwing errors for non-successful requests. This fixes a bug where non-200 HTTP responses were incorrectly treated as successful operations.
- Adds response status validation using
response.ok - Implements error logging for failed requests
- Throws descriptive errors for failed fetch operations
Comments suppressed due to low confidence (1)
api/src/fetch/service.ts:53
- [nitpick] The error message could be more informative by including the HTTP status code. Consider changing to:
Failed to fetch ${url}: ${response.status} ${response.statusText}
throw new Error(`Failed to fetch ${url}: ${response.statusText}`);
The change updates the project processing logic. Instead of deleting invalid projects, they are now marked as garbage-collected. Tags and search indices are only processed after valid repositories are confirmed.
omdxp
reviewed
Aug 1, 2025
omdxp
previously approved these changes
Aug 1, 2025
omdxp
approved these changes
Aug 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.