-
Notifications
You must be signed in to change notification settings - Fork 753
Add writeFiles function to js sdk #1084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 255c82d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| assert.equal(emptyInfo.length, 0) | ||
| }) | ||
|
|
||
| sandboxTest('writeFiles with single file', async ({ sandbox }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's remove this test
mishushakov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update the comment in index.ts, add clean up to the tests and add a changeset
pnpm changeset
To fix the inconsistency between the Python SDK and the JS SDK, add writeFiles to the JS SDK. (no changes made to write function)