Conversation
|
I think the pin was originally there to fix some dependency collision/incompatiblity—it stopped being a problem? :D |
We're using Loki v2 and afaik, the Go client v3 is not compatible with it. |
infra/iac/provider-gcp/nomad/jobs/loki.hcl Line 135 in 07c612a I see, so we are waiting for this switch of schema too? |
|
Converting to draft until Loki v3 is merged |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7efe4aa071
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Note
Medium Risk
Large dependency upgrades (including Loki/OTel/Kubernetes libs) can introduce subtle runtime or build-time incompatibilities and should be validated via integration tests and deployment smoke checks.
Overview
Updates the API module’s Go dependencies to newer upstream versions (notably moving to
github.com/grafana/loki/v3) and drops several previously pinnedreplace/excludeoverrides, with corresponding import path updates for Loki’slogproto. It also tweaks build/infra tooling by making the roottidytarget quiet and adding a new Terraform var (LOKI_USE_V13_SCHEMA_FROM) to the GCP provider Makefile.Written by Cursor Bugbot for commit 7ae8d11. This will update automatically on new commits. Configure here.