Allow checks to use results from other checks#8
Merged
lukpueh merged 7 commits intoeclipse-csi:mainfrom Feb 5, 2026
Merged
Conversation
Signed-off-by: Lukas Puehringer <lukas.puehringer@eclipse-foundation.org>
The Config class, currently used to provide cli args to Checks, becomes the Context class, used for this purpose, but also to gather all Check results. See subsequent commits for the latter. Signed-off-by: Lukas Puehringer <lukas.puehringer@eclipse-foundation.org>
Write the result to the Context.data dictionary, using the check id as dictionary key. Signed-off-by: Lukas Puehringer <lukas.puehringer@eclipse-foundation.org>
Allow any result from Check.run, instead of just a scalar value, to allow the collection of rich data, for later analysis. Signed-off-by: Lukas Puehringer <lukas.puehringer@eclipse-foundation.org>
Now that we can return rich results from a check, we use the whole API response, and change the name accordingly. Signed-off-by: Lukas Puehringer <lukas.puehringer@eclipse-foundation.org>
This allows checks to use results from other checks **Details** * Add depends_on field to check base class, to define dependencies on other checks. Checks are identified by their check id (i.e. module name). * Update run_checks to run checks in waves. Start with checks that don't have dependencies, then run checks, whose dependencies have completed, and repeat until no checks are left to run. Signed-off-by: Lukas Puehringer <lukas.puehringer@eclipse-foundation.org>
Print all check results in context.data to stdout eventually, and use logging module to give feedback about failed checks. Also remove the now obsolete formatter module and the CheckResult class. Signed-off-by: Lukas Puehringer <lukas.puehringer@eclipse-foundation.org>
iliescuioana
approved these changes
Feb 4, 2026
kairoaraujo
reviewed
Feb 4, 2026
kairoaraujo
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #5
Change details
Review commit by commit is recommended