Add dependency required in test-time

[pzygielo]

No description provided.

[pzygielo]

May I ask for review, please?

[dmatej]

Wait a second! This is not a solution, we hit that on Metro today (and few weeks ago), I did exactly this, but @lukasj pointed out that the impl should not be required in some cases (when JMX is disabled, so we don't need any impl, just the NOOP).

I will fix it tomorrow in gmbal:

• The IllegalStateException will be thrown from those two methods, when we did not find any service in the static block.
• The NOOP will remain unchanged. However, maybe the class could be nonfinal and public, so it could be extended in custom implementations.

[dmatej]

Btw, is it passing without that?
EDIT: CI doesn't run tests!

[pzygielo]

Btw, is it passing without that?

No.

That's why I ask for this to be merged in. If there is something to be fixed and then included here - then this might go. But now it's needed.

[pzygielo]

CI doesn't run tests!

#265 (comment):

Perhaps it would be good to execute at least some tests (from modified module) during CI build.

[dmatej]

How do you run tests? master passed when I ran just mvn clean install
Aha ... mvn clean install -Pall-tests
Hmm:

1. SecurityManager on JDK25 fails all tests
2. Despite all tests do fail, the maven build was successful.

[pzygielo]

1. SecurityManager on JDK25 fails all tests

• Strange. Do you have Updates for deprecated SecurityManager #266 pulled?

[dmatej]

Sure, but that is nogo with JDK25.
However I will approve this, because I see this in the project used:

    @OrbLifeCycle
    public void createORBManagedObjectManager() {
        if (rootParentObjectName == null) {
            mom = ManagedObjectManagerFactory.createStandalone( "com.sun.corba" ) ;
        } else {
            mom = ManagedObjectManagerFactory.createFederated( rootParentObjectName ) ;
        }

So I guess it is simply mandatory to have some implementation.

[pzygielo]

Sure, but that is nogo with JDK25.

Right, it produces

A command line option has attempted to allow or enable the Security Manager

But the added dependency is not a reason for that. 😄

And I used this to run single test:

mvn \
   -f functional-tests   \
   antrun:run@run-tests  \
   -Dtest.args="-test rmic.StaticStringsHashTest -verbose"

[pzygielo]

I see locally I still have at least one change waiting to be included for tests to go - to set property

    <jvmarg value="-Dorg.glassfish.gmbal.no.multipleUpperBoundsException=true"/>