Skip to content

Conversation

@eclipse-pde-bot
Copy link
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

The following Manifest cleanups where applied:

  • Calculate 'uses' directive for public packages
  • Remove unused dependencies

@eclipse-eca-validation
Copy link

Hi @eclipse-pde-bot — thank you for your contribution!

The Eclipse Contributor Agreement (ECA) check has failed for this pull request due to one of the following reasons:

  • An Eclipse Contributor Agreement is required for Eclipse user 'genie.pde'(committer).
  • An Eclipse Contributor Agreement is required for Eclipse user 'genie.pde'(author).

To resolve this, please:

  1. Sign in or create an Eclipse Foundation account: https://accounts.eclipse.org/user/eca
  2. Ensure your GitHub username is linked to your Eclipse account
  3. Complete and submit the ECA form

Once done, push a new commit (or rebase) to re-trigger the ECA validation.

If you believe you've already completed these steps, please double-check your account settings or report an issue to Eclipse Foundation Helpdesk.

Thanks again for your contribution!

@eclipse-pde-bot
Copy link
Contributor Author

eclipse-pde-bot commented Jan 17, 2026

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

e4tools/bundles/org.eclipse.e4.tools.emf.editor3x/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From f6b0050291d9c80774d8ea0370c5e00fe8a76787 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Sun, 18 Jan 2026 03:24:41 +0000
Subject: [PATCH] Version bump(s) for 4.39 stream


diff --git a/e4tools/bundles/org.eclipse.e4.tools.emf.editor3x/META-INF/MANIFEST.MF b/e4tools/bundles/org.eclipse.e4.tools.emf.editor3x/META-INF/MANIFEST.MF
index 4f5bfa4037..5cce55fb06 100644
--- a/e4tools/bundles/org.eclipse.e4.tools.emf.editor3x/META-INF/MANIFEST.MF
+++ b/e4tools/bundles/org.eclipse.e4.tools.emf.editor3x/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Bundle-Name
 Bundle-SymbolicName: org.eclipse.e4.tools.emf.editor3x;singleton:=true
-Bundle-Version: 4.10.100.qualifier
+Bundle-Version: 4.10.200.qualifier
 Bundle-RequiredExecutionEnvironment: JavaSE-21
 Require-Bundle: org.eclipse.ui;bundle-version="3.6.0",
  org.eclipse.core.runtime;bundle-version="3.29.0",
-- 
2.52.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link

github-actions bot commented Jan 17, 2026

Test Results

   798 files  ±0     798 suites  ±0   56m 21s ⏱️ +40s
 3 732 tests ±0   3 595 ✅  - 1  136 💤 ±0  1 ❌ +1 
11 127 runs  ±0  10 717 ✅  - 1  409 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit dff94b6. ± Comparison against base commit d117e1d.

♻️ This comment has been updated with latest results.

@eclipse-pde-bot eclipse-pde-bot force-pushed the clean-code/e4tools/bundles/org.eclipse.e4.tools.emf.editor3x branch from f60bcc4 to c99f92a Compare January 18, 2026 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants