Skip to content

Replacing usages of Display#getDPI in snippets #2868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShahzaibIbrahim wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −5
Open

Replacing usages of Display#getDPI in snippets #2868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...es/org.eclipse.swt.examples/src/org/eclipse/swt/examples/imageanalyzer/ImageAnalyzer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1166,16 +1166,16 @@ void menuPrint() {
if (image == null) return;

try {
final int DOTS_PER_INCH = 96;
// Ask the user to specify the printer.
PrintDialog dialog = new PrintDialog(shell, SWT.NONE);
if (printerData != null) dialog.setPrinterData(printerData);
printerData = dialog.open();
if (printerData == null) return;

Printer printer = new Printer(printerData);
Point screenDPI = display.getDPI();
Point printerDPI = printer.getDPI();
int scaleFactor = printerDPI.x / screenDPI.x;
int scaleFactor = printerDPI.x / DOTS_PER_INCH;
Rectangle trim = printer.computeTrim(0, 0, 0, 0);
if (printer.startJob(currentName)) {
if (printer.startPage()) {
Expand Down
4 changes: 2 additions & 2 deletions examples/org.eclipse.swt.snippets/src/org/eclipse/swt/snippets/Snippet361.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ public void getName(AccessibleEvent e) {
}

private static void performPrintAction(final Display display, final Shell shell) {
final int DOTS_PER_INCH = 96;
Rectangle r = composite.getBounds();
Point p = shell.toDisplay(r.x, r.y);
org.eclipse.swt.graphics.Image snapshotImage
Expand All @@ -159,9 +160,8 @@ private static void performPrintAction(final Display display, final Shell shell)
data = dialog.open();
if (data != null) {
Printer printer = new Printer(data);
Point screenDPI = display.getDPI();
Point printerDPI = printer.getDPI();
int scaleFactor = printerDPI.x / screenDPI.x;
int scaleFactor = printerDPI.x / DOTS_PER_INCH;
Rectangle trim = printer.computeTrim(0, 0, 0, 0);
if (printer.startJob("Print Image")) {
ImageData imageData = snapshotImage.getImageData();
Expand Down
2 changes: 1 addition & 1 deletion examples/org.eclipse.swt.snippets/src/org/eclipse/swt/snippets/Snippet367.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ public int getGcStyle() {

createSeparator(shell);

new Label (shell, SWT.NONE).setText ("5. 50x50 box\n(Display#getDPI(): " + display.getDPI().x + ")");
new Label (shell, SWT.NONE).setText ("5. 50x50 box");
Label box= new Label (shell, SWT.NONE);
box.setBackground(display.getSystemColor(SWT.COLOR_WIDGET_DARK_SHADOW));
box.setLayoutData (new GridData (50, 50));
Expand Down
Loading