Skip to content

Deprecating Display#getDPI #2872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShahzaibIbrahim wants to merge 1 commit into
base: master
Choose a base branch
from
+39 −5
Open

Deprecating Display#getDPI #2872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions bundles/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/graphics/Device.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,18 @@ public int getDepth () {
* @exception SWTException <ul>
* <li>ERROR_DEVICE_DISPOSED - if the receiver has been disposed</li>
* </ul>
*
* @deprecated <p>This method returns a single global DPI value
* that does not reflect per-monitor DPI settings on modern operating systems.
* In environments with different scaling factors across monitors, it may provide
* a misleading or meaningless result, as it does not correspond to the actual DPI
* of any specific monitor.</p>
*
* <p>Note: While deprecated for general {@code Device} instances like {@code Display},
* this method may still be validly used when called on a {@code Printer} instance,
* where a single global DPI value is meaningful and expected.</p>
*/
@Deprecated
public Point getDPI () {
checkDevice ();
return getScreenDPI();
Expand Down Expand Up @@ -611,8 +622,9 @@ protected void init () {
/* Initialize the system font slot */
boolean smallFonts = System.getProperty("org.eclipse.swt.internal.carbon.smallFonts") != null;
double systemFontSize = smallFonts ? NSFont.smallSystemFontSize() : NSFont.systemFontSize();
Point dpi = this.dpi = getDPI(), screenDPI = getScreenDPI();
NSFont font = NSFont.systemFontOfSize(systemFontSize * dpi.y / screenDPI.y);
final int DOTS_PER_INCH = 72;
Point dpi = this.dpi = getDPI();
NSFont font = NSFont.systemFontOfSize(systemFontSize * dpi.y / DOTS_PER_INCH);
font.retain();
systemFont = Font.cocoa_new(this, font);
}
Expand Down
17 changes: 14 additions & 3 deletions bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/graphics/Device.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,18 @@ public int getDepth () {
* @exception SWTException <ul>
* <li>ERROR_DEVICE_DISPOSED - if the receiver has been disposed</li>
* </ul>
*
* @deprecated <p>This method returns a single global DPI value
* that does not reflect per-monitor DPI settings on modern operating systems.
* In environments with different scaling factors across monitors, it may provide
* a misleading or meaningless result, as it does not correspond to the actual DPI
* of any specific monitor.</p>
*
* <p>Note: While deprecated for general {@code Device} instances like {@code Display},
* this method may still be validly used when called on a {@code Printer} instance,
* where a single global DPI value is meaningful and expected.</p>
*/
@Deprecated
public Point getDPI () {
checkDevice ();
return getScreenDPI();
Expand Down Expand Up @@ -641,6 +652,7 @@ public boolean getWarnings () {
* @see #create
*/
protected void init () {
final int DOTS_PER_INCH = 96;
if (debug) {
if (xDisplay != 0) {
/* Create the warning and error callbacks */
Expand Down Expand Up @@ -723,10 +735,9 @@ protected void init () {
}
}
defaultFont = OS.pango_font_description_copy (defaultFont);
Point dpi = getDPI(), screenDPI = getScreenDPI();
if (dpi.y != screenDPI.y) {
if (this.dpi.y != DOTS_PER_INCH) {
int size = OS.pango_font_description_get_size(defaultFont);
OS.pango_font_description_set_size(defaultFont, size * dpi.y / screenDPI.y);
OS.pango_font_description_set_size(defaultFont, size * this.dpi.y / DOTS_PER_INCH);
}
systemFont = Font.gtk_new (this, defaultFont);

Expand Down
11 changes: 11 additions & 0 deletions bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Device.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,18 @@ public int getDepth () {
* @exception SWTException <ul>
* <li>ERROR_DEVICE_DISPOSED - if the receiver has been disposed</li>
* </ul>
*
* @deprecated <p>This method returns a single global DPI value
* that does not reflect per-monitor DPI settings on modern operating systems.
* In environments with different scaling factors across monitors, it may provide
* a misleading or meaningless result, as it does not correspond to the actual DPI
* of any specific monitor.</p>
*
* <p>Note: While deprecated for general {@code Device} instances like {@code Display},
* this method may still be validly used when called on a {@code Printer} instance,
* where a single global DPI value is meaningful and expected.</p>
*/
@Deprecated
public Point getDPI () {
checkDevice ();
long hDC = internal_new_GC (null);
Expand Down
Loading