Skip to content

Add more comprehensive information on timeout in BusyIndicator Test #3051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
laeubi wants to merge 5 commits into
base: master
Choose a base branch
from
+361 −96
Open

Add more comprehensive information on timeout in BusyIndicator Test #3051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b244355
Add more comprehensive information on timeout in BusyIndicator Test
laeubi Feb 4, 2026
1658e8c
More dbeugging, kill the JVM once watchdog has fired!
laeubi Feb 4, 2026
1d33283
Print more
laeubi Feb 4, 2026
675b381
Update debugging infos
laeubi Feb 4, 2026
8019d34
Dont exit vm
laeubi Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions binaries/org.eclipse.swt.gtk.linux.x86_64/.settings/.api_filters
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,32 +1,38 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<component id="org.eclipse.swt.gtk.linux.x86_64" version="2">
<resource path="Eclipse SWT/gtk/org/eclipse/swt/widgets/Composite.java" type="org.eclipse.swt.widgets.Composite">
<filter id="576778288">
<resource path="Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/BusyIndicator.java" type="org.eclipse.swt.custom.BusyIndicator">
<filter id="336658481">
<message_arguments>
<message_argument value="Scrollable"/>
<message_argument value="Composite"/>
<message_argument value="org.eclipse.swt.custom.BusyIndicator"/>
<message_argument value="onWake"/>
</message_arguments>
</filter>
<filter id="336658481">
<message_arguments>
<message_argument value="org.eclipse.swt.custom.BusyIndicator"/>
<message_argument value="onWakeError"/>
</message_arguments>
</filter>
</resource>
<resource path="Eclipse SWT/common/org/eclipse/swt/graphics/ImageDataAtSizeProvider.java" type="org.eclipse.swt.graphics.ImageDataAtSizeProvider">
<filter id="403804204" comment="Adding API filter to mark ImageDataAtSizeProvider as referenceable">
<filter comment="Adding API filter to mark ImageDataAtSizeProvider as referenceable" id="403804204">
<message_arguments>
<message_argument value="org.eclipse.swt.graphics.ImageDataAtSizeProvider"/>
<message_argument value="getDefaultSize()"/>
</message_arguments>
</filter>
<filter id="1211105284" comment="Adding API filter to mark ImageDataAtSizeProvider as referenceable">
<filter comment="Adding API filter to mark ImageDataAtSizeProvider as referenceable" id="403804204">
<message_arguments>
<message_argument value="getDefaultSize()"/>
<message_argument value="org.eclipse.swt.graphics.ImageDataAtSizeProvider"/>
<message_argument value="getImageData(int, int)"/>
</message_arguments>
</filter>
<filter id="403804204" comment="Adding API filter to mark ImageDataAtSizeProvider as referenceable">
<filter comment="Adding API filter to mark ImageDataAtSizeProvider as referenceable" id="1211105284">
<message_arguments>
<message_argument value="org.eclipse.swt.graphics.ImageDataAtSizeProvider"/>
<message_argument value="getImageData(int, int)"/>
<message_argument value="getDefaultSize()"/>
</message_arguments>
</filter>
<filter id="1211105284" comment="Adding API filter to mark ImageDataAtSizeProvider as referenceable">
<filter comment="Adding API filter to mark ImageDataAtSizeProvider as referenceable" id="1211105284">
<message_arguments>
<message_argument value="getImageData(int, int)"/>
</message_arguments>
Expand Down
15 changes: 15 additions & 0 deletions ...g.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/BusyIndicator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
import java.util.*;
import java.util.concurrent.*;
import java.util.concurrent.atomic.*;
import java.util.function.*;

import org.eclipse.swt.*;
import org.eclipse.swt.graphics.*;
Expand All @@ -33,6 +34,14 @@ public class BusyIndicator {
private static final AtomicInteger nextBusyId = new AtomicInteger();
static final String BUSYID_NAME = "SWT BusyIndicator"; //$NON-NLS-1$
static final String BUSY_CURSOR = "SWT BusyIndicator Cursor"; //$NON-NLS-1$
/**
* @noreference This field is not intended to be referenced by clients.
*/
public static Runnable onWake;
/**
* @noreference This field is not intended to be referenced by clients.
*/
public static Consumer<Exception> onWakeError;

/**
* Runs the given <code>Runnable</code> while providing
Expand Down Expand Up @@ -111,8 +120,14 @@ public static void showWhile(Future<?> future) {
stage.handle((nil1, nil2) -> {
if (!display.isDisposed()) {
try {
if (onWake!=null) {
onWake.run();
}
display.wake();
} catch (SWTException e) {
if (onWakeError!=null) {
onWakeError.accept(e);
}
// ignore then, this can happen due to the async nature between our check for
// disposed and the actual call to wake the display can be disposed
}
Expand Down
Loading
Loading