[Win32] Properly reinitialize image of items on DPI changes #3074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current logic for reinitializing the image of an item on DPI changes is insufficient as the default implementation of the called setImage() method and many of the overwrites of that method do an early return in case the image equals to the one that has already been set. In order to force a reinitialization of the image, this change ensures that the image is first removed and then reset. Fixes eclipse-platform#3073
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic for reinitializing the image of an item on DPI changes is insufficient as the default implementation of the called setImage() method and many of the overwrites of that method do an early return in case the image equals to the one that has already been set.
In order to force a reinitialization of the image, this change ensures that the image is first removed and then reset.
Fixes #3073