Fix view_menu.svg

[sratz]

view_menu.svg was the wrong svg file, not matching the .pngs.

Follow-up on #2925.

Supercedes and thus closes #2995.

[sratz]

Was:

Should be:

[HeikoKlare]

Just saw that we did the same thing at almost the same time :-)

• Correct SVG icon for showing menu in part stacks and shared images #2995

However, note that the icon you propose is not correct. The existing SVG is not properly centered/sized. This is how it looks for me with your PR:

[sratz]

Oh wow, we have like a million different versions of the same svg lying around :D

[HeikoKlare]

Oh wow, we have like a million different versions of the same svg lying around :D

Yeah, there were many SVGs for this, some were completely "wrong" (like the one you replaced), some just wrongly size. But actually I found none that completely fits to the existing PNGs. So the SVG I propose in #2995 is even a new one created out of the existing ones. Maybe I just missed the "correct" one lying around somewhere.

[BeckerWdf]

Oh wow, we have like a million different versions of the same svg lying around :D

Ups. Sorry. Maybe I messed this up years ago without noticing.

[sratz]

I updated all the icons with eclipse-platform/eclipse.platform.images#147, which is based on @HeikoKlare 's icon proposed in #2995.

[github-actions]

Test Results

 1 824 files  ±0   1 824 suites  ±0   1h 41m 1s ⏱️ - 1m 32s
 7 925 tests ±0   7 697 ✅ ±0  228 💤 ±0  0 ❌ ±0 
23 862 runs  ±0  23 114 ✅ ±0  748 💤 ±0  0 ❌ ±0 

Results for commit 6dd5aa6. ± Comparison against base commit 710a26a.

[HeikoKlare]

Looks really great. Thank you, @sratz!

The icon now fits even better to the minimize/maximize icons next to them in the part stacks, as the stroke widths are better aligned. In addition, I tested on all fractional scales between 100% and 200% monitor zoom and it really looks good and much better than the previous PNG icon on all zoom levels.

Btw: the minimize/maximize icons are rendered programmatically. I quickly tried to do the same for the view_menu icon, but unfortunately GC-rendered circles do not look that good (even with anti-aliasing), which is why I cannot recommend trying out.

[sratz]

Thanks, @HeikoKlare for the tests and the initial version of the updated icon!

I suppose we are good to merge this for RC1?

[HeikoKlare]

I suppose we are good to merge this for RC1?

Yes, +1 for doing so.