Guard clipping to avoid resize artifacts in tree viewer #3573
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the clipping region temporarily to the textBounds was originally added (https://bugs.eclipse.org/bugs/show_bug.cgi?id=291245 comment 25) to prevent images from being overdrawn when implementting RIGHT or CENTER column alignment support in StyledCellLabelProvider. However, enabling clipping causes artifact lines during tree resizing, as a temporary workaround the clipping call is now guarded and applied only in those alignment cases to avoid issues with resizing of columns.
Contributor
akoch-yatta
approved these changes
Dec 12, 2025
Contributor
akoch-yatta
left a comment
akoch-yatta
left a comment
There was a problem hiding this comment.
Tested with the Runtime and the mentioned Snippet. Adapted the Snippet to be able to test with TreeViewer and TableViewer. This PR works with both scenarios. TreeViewer doesn't properly work with SWT.RIGHT and SWT.CENTER when the first column is resized (at least in windows), but this is a pre-existing and not caused or worsened with this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the clipping region temporarily to the textBounds was originally added (https://bugs.eclipse.org/bugs/show_bug.cgi?id=291245 comment 25) to prevent images from being overdrawn when implementting RIGHT or CENTER column alignment support in StyledCellLabelProvider. However, enabling clipping causes artifact lines during tree resizing, as a temporary workaround the clipping call is now guarded and applied only in those alignment cases to avoid issues with resizing of columns.
Steps to reproduce
Step 0:Set monitor zoom to 175
Behavior without the fix
old.mp4
Behavior with the fix
new.mp4
Additionally this issue can also be reproduced with the snippet provided in vi-eclipse/Eclipse-Platform#548 (comment)