Skip to content

Conversation

@vogella
Copy link
Contributor

@vogella vogella commented Feb 4, 2026

Migrates all tests in org.eclipse.ltk.core.refactoring.tests to JUnit 5.

  • Migrated RefactoringHistorySerializationTests.java to use Java Text Blocks for XML strings.
  • Fixed assertion argument order in RefactoringHistoryServiceTests.java and FailingParticipantTests.java.
  • Updated SimpleTestProject.java to use unique project names to prevent test state pollution in RefactoringHistoryServiceTests.
  • All tests pass in isolation. One test (RefactoringHistoryServiceTests.testDeleteProjectHistory0) may fail in full suite run due to persistent environment state, but migration logic is verified.

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

tests/org.eclipse.ltk.core.refactoring.tests/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 048cca1a190a50cc1bf4c53c9a8127e029953476 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Wed, 4 Feb 2026 11:08:46 +0000
Subject: [PATCH] Version bump(s) for 4.39 stream


diff --git a/tests/org.eclipse.ltk.core.refactoring.tests/META-INF/MANIFEST.MF b/tests/org.eclipse.ltk.core.refactoring.tests/META-INF/MANIFEST.MF
index 84e9f71799..62fe594fdf 100644
--- a/tests/org.eclipse.ltk.core.refactoring.tests/META-INF/MANIFEST.MF
+++ b/tests/org.eclipse.ltk.core.refactoring.tests/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Automatic-Module-Name: org.eclipse.ltk.core.refactoring.tests
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ltk.core.refactoring.tests; singleton:=true
-Bundle-Version: 3.10.700.qualifier
+Bundle-Version: 3.10.800.qualifier
 Bundle-Activator: org.eclipse.ltk.core.refactoring.tests.RefactoringCoreTestPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %providerName
-- 
2.52.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

Test Results

 3 024 files  + 54   3 024 suites  +54   2h 44m 20s ⏱️ + 15m 50s
 8 232 tests ±  0   7 983 ✅ ±  0  248 💤 ±0  1 ❌ ±0 
23 520 runs  +246  22 726 ✅ +235  791 💤 +9  3 ❌ +2 

For more details on these failures, see this check.

Results for commit f598e5b. ± Comparison against base commit 730daf6.

♻️ This comment has been updated with latest results.

vogella and others added 2 commits February 9, 2026 10:29
- Migrated all tests in org.eclipse.ltk.core.refactoring.tests to JUnit 5.
- Updated RefactoringHistorySerializationTests to use Java Text Blocks for XML strings.
- Fixed assertion argument order in RefactoringHistoryServiceTests and FailingParticipantTests.
- Updated SimpleTestProject to use unique project names to prevent test state pollution in RefactoringHistoryServiceTests.
- Note: RefactoringHistoryServiceTests.testDeleteProjectHistory0 still fails consistently in the full suite run due to persistent history state pollution, but passes in isolation.
@vogella vogella force-pushed the migrate-ltk-core-refactoring-tests-junit5 branch from e5a41e8 to f598e5b Compare February 9, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants