Update of the FAQ Log entry #1623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@HannesWell WDTY? @thahnen FYI, we like to see more PR from you (also code related if you find the time). |
Contributor
merks
reviewed
Nov 20, 2024
| public static void test(){ | ||
| try { | ||
| log("Eclipse Style Logging"); | ||
| ILog.get().info("Starting"); |
Contributor
There was a problem hiding this comment.
Maybe it's not a good idea to use tabs.
merks
reviewed
Nov 20, 2024
| log("Eclipse Style Logging"); | ||
| // do something that may cause an exception | ||
| } | ||
| catch(Exception e){ |
Contributor
There was a problem hiding this comment.
Nit.
Suggested change
| catch(Exception e){ | |
| catch (Exception e){ |
Lets promote ILog.get() instead Platform.getLog():
Contributor
Author
|
Ignoring freeze as this is only online documentation |
HannesWell
approved these changes
Nov 20, 2024
Member
HannesWell
left a comment
HannesWell
left a comment
There was a problem hiding this comment.
Thanks. I personally also prefer the new code.
I just wonder if the example should be put in a markdown code block wrapped in three back-ticks.
| ... | ||
| public class MyLogger { | ||
| ... | ||
| private static final Bundle BUNDLE = FrameworkUtil.getBundle(MyLogger.class); |
Member
There was a problem hiding this comment.
Is this line still necessary?
At least while viewing this on the phone I can't see a reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets promote ILog.get() instead Platform.getLog():