Don't use SubMonitor when saving project in SaveManager

[ptziegler]

The migration from the IProgressMonitor to the SubMonitor done as part of 40114d2 also converts the progress monitor used within the InternalMonitorWrapper.

If the parent monitor is a SubMonitor, this calls beginTask() both when the InternalMonitorWrapper is created, as well as explicitly later on. To avoid this, switch back to create a null-safe progress monitor via Policy.monitorFor(...).

Closes #1758

[ptziegler]

The other usages of the SubMonitor look fine, so that seems to be the only place that needs to be adapted.

[ptziegler]

I noticed that Policy.monitorFor

eclipse.platform/resources/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/utils/Policy.java

Lines 177 to 179 in 8186345

	public static IProgressMonitor monitorFor(IProgressMonitor monitor) {
	return monitor == null ? new NullProgressMonitor() : monitor;
	}

and IProgressMonitor.nullSafe(...)

static IProgressMonitor nullSafe(IProgressMonitor monitor) {
    if (monitor == null) {
        return new NullProgressMonitor();
    }
    return monitor;
}

are functionally identical. It probably makes sense to get rid of the former altogether...

[eclipse-platform-bot]

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

resources/bundles/org.eclipse.core.resources/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From 9cf771f7999fd3dcd4f5d5b6aaf92fbaefcd93a2 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Wed, 5 Mar 2025 19:03:41 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/resources/bundles/org.eclipse.core.resources/META-INF/MANIFEST.MF b/resources/bundles/org.eclipse.core.resources/META-INF/MANIFEST.MF
index 5c1c77c5da..aa042e2f42 100644
--- a/resources/bundles/org.eclipse.core.resources/META-INF/MANIFEST.MF
+++ b/resources/bundles/org.eclipse.core.resources/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.core.resources; singleton:=true
-Bundle-Version: 3.22.100.qualifier
+Bundle-Version: 3.22.200.qualifier
 Bundle-Activator: org.eclipse.core.resources.ResourcesPlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.48.1

Further information are available in Common Build Issues - Missing version increments.

[github-actions]

Test Results

1 191 files   -  65  1 191 suites   - 65   59m 1s ⏱️ - 2m 23s
4 173 tests ±  0  4 127 ✅ +  1   46 💤  - 1  0 ❌ ±0 
9 312 runs   - 267  9 191 ✅  - 264  121 💤  - 3  0 ❌ ±0 

Results for commit a0bb0d5. ± Comparison against base commit 14db9ea.

♻️ This comment has been updated with latest results.

[ptziegler]

The failure on the Windows node also happens on the master, so it's likely unrelated.