Skip to content

Conversation

@HeikoKlare
Copy link
Contributor

@HeikoKlare HeikoKlare commented Mar 30, 2025

@HeikoKlare HeikoKlare marked this pull request as ready for review March 30, 2025 16:25
@HeikoKlare HeikoKlare requested a review from sratz March 30, 2025 16:25
@github-actions
Copy link
Contributor

Test Results

 1 599 files  ±0   1 599 suites  ±0   1h 23m 58s ⏱️ - 2m 3s
 4 173 tests ±0   4 150 ✅ +1   23 💤 ±0  0 ❌  - 1 
12 001 runs  ±0  11 835 ✅ +1  166 💤 ±0  0 ❌  - 1 

Results for commit 7df0a3a. ± Comparison against base commit eca8380.

In case you want to use fixed-version binaries or override the automatically chosen version, set the `org.eclipse.swt.browser.EdgeDir` Java property to the directory containing `msedgewebview2.exe`. For example:

```sh
java "-Dorg.eclipse.swt.browser.EdgeDir=C:\Program Files (x86)\Microsoft\Edge Beta\Application\88.0.705.29" ...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting Eclipse via a java command isn't that common.
Should the example just mention the 'system property' and not give a command line example?
Or, alternatively, mention to modify the eclipse.ini`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. This is probably only relevant when having a pure SWT application. I have reduced this to a sentence mentioning the system property and referring to the eclipse.ini for Eclipse products.

_Note: As of Eclipse/SWT 4.8, Mozilla (`XULRunner`) renderer is no longer supported, the value `mozilla` has no effect._

A user can specify a comma-separated list of native renderers, in order of preference, for the `org.eclipse.swt.browser.DefaultType` value. Values not applicable to a particular platform are ignored. For example, the value of `edge,chromium` will change the default to Edge on Windows and Chromium on other platforms.
A user can specify a comma-separated list of native renderers, in order of preference, for the `org.eclipse.swt.browser.DefaultType` value. Values not applicable to a particular platform are ignored. For example, the value of `ie,chromium` will change the default to Internet Explorer on Windows and Chromium on other platforms.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seeing as chromium is not supported anymore, should we replace this constant with webkit?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do so.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I also added the deprecation information to the where the CHROMIUM flag is mentioned.

@vogella
Copy link
Contributor

vogella commented Mar 31, 2025

LGTM

@HeikoKlare
Copy link
Contributor Author

Thanks for your feedback! I adapted everything accordingly.

@HeikoKlare HeikoKlare merged commit 9e339b2 into eclipse-platform:master Mar 31, 2025
16 of 17 checks passed
@HeikoKlare HeikoKlare deleted the edge-faq branch March 31, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants