Mark removal for unused deprecated methods in o.e.compare #2195
+13
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iloveeclipse
requested changes
Oct 10, 2025
...rg.eclipse.compare/compare/org/eclipse/compare/structuremergeviewer/StructureDiffViewer.java
Outdated
Show resolved
Hide resolved
merks
previously requested changes
Oct 10, 2025
team/bundles/org.eclipse.compare/compare/org/eclipse/compare/CompareEditorInput.java
Outdated
Show resolved
Hide resolved
SougandhS
force-pushed
the
MarkDeprecatedForRemoval
branch
2 times, most recently
from
e8b26eb to
83f44e6
Compare
Contributor
SougandhS
force-pushed
the
MarkDeprecatedForRemoval
branch
from
83f44e6 to
435fc5c
Compare
...rg.eclipse.compare/compare/org/eclipse/compare/structuremergeviewer/StructureDiffViewer.java
Outdated
Show resolved
Hide resolved
SougandhS
force-pushed
the
MarkDeprecatedForRemoval
branch
from
435fc5c to
f14e249
Compare
iloveeclipse
approved these changes
Oct 14, 2025
SougandhS
force-pushed
the
MarkDeprecatedForRemoval
branch
2 times, most recently
from
5b25b26 to
e43c04c
Compare
Contributor
Author
|
Hi @merks |
SougandhS
force-pushed
the
MarkDeprecatedForRemoval
branch
from
e43c04c to
e102211
Compare
SougandhS
force-pushed
the
MarkDeprecatedForRemoval
branch
from
e102211 to
18756f6
Compare
SougandhS
force-pushed
the
MarkDeprecatedForRemoval
branch
2 times, most recently
from
d793ecc to
29edbed
Compare
Contributor
Author
|
Hi @merks, the build looks good now, if there are no more changes can this be merged ? |
akurtakov
force-pushed
the
MarkDeprecatedForRemoval
branch
2 times, most recently
from
79a0565 to
135fc9b
Compare
Member
|
Please change the since to 2026-03 as 2025-12 is done deal now. |
SougandhS
force-pushed
the
MarkDeprecatedForRemoval
branch
2 times, most recently
from
4337cef to
2eefbcf
Compare
Contributor
Author
Updated now 👍 |
SougandhS
force-pushed
the
MarkDeprecatedForRemoval
branch
from
2eefbcf to
dadc46a
Compare
akurtakov
dismissed
merks’s stale review
Dismissing as the request was fullfilled.
Contributor
Author
|
Thank you all.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.